[jira] [Comment Edited] (CASSANDRA-8832) SSTableRewriter.abort() should be more robust to failure

["Branimir Lambov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345460#comment-14345460 ] 

Branimir Lambov edited comment on CASSANDRA-8832 at 3/3/15 6:39 PM:
--------------------------------------------------------------------

AFAICS the actual fix for the problem was committed [as part of 7705|https://github.com/apache/cassandra/commit/c75ee4160cb8fcdf47c90bfce8bf0d861f32d268#diff-426d04d201a410848604b55984d1b370R291] and this patch only adds continued processing after exceptions. Can you confirm this?

A couple of comments on the patch:
* {{replaceWithFinishedReaders}} can also throw (e.g. due to a reference counting bug), hiding any earlier errors. It should also be wrapped in a try/merge block.
* The static {{merge}} of throwables will probably be needed in many other places. Could we move it to a more generic location?
* Is it possible to include a regression test for the bug?


was (Author: blambov):
AFAICS the actual fix for the problem was committed [as part of 7705|https://github.com/apache/cassandra/commit/c75ee4160cb8fcdf47c90bfce8bf0d861f32d268] and this patch only adds continued processing after exceptions. Can you confirm this?

A couple of comments on the patch:
* {{replaceWithFinishedReaders}} can also throw (e.g. due to a reference counting bug), hiding any earlier errors. It should also be wrapped in a try/merge block.
* The static {{merge}} of throwables will probably be needed in many other places. Could we move it to a more generic location?
* Is it possible to include a regression test for the bug?

> SSTableRewriter.abort() should be more robust to failure
> --------------------------------------------------------
>
>                 Key: CASSANDRA-8832
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8832
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>             Fix For: 2.1.4
>
>
> This fixes a bug introduced in CASSANDRA-8124 that attempts to open early during abort, introducing a failure risk. This patch further preempts CASSANDRA-8690 to wrap every rollback action in a try/catch block, so that any internal assertion checks do not actually worsen the state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)