You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/04/21 13:37:46 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request, #2818: apps/pwm_test: Fix configuration for nucleo boards
kasjer opened a new pull request, #2818:
URL: https://github.com/apache/mynewt-core/pull/2818
Code assumed that NUCLEO_F767ZI, NUCLEO_F303RE or NUCLEO_F303K8
are defined for respective board while it's not.
Preprocessor condition changed to reflect currently present definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2818: apps/pwm_test: Fix configuration for nucleo boards
Posted by GitBox <gi...@apache.org>.
kasjer merged PR #2818:
URL: https://github.com/apache/mynewt-core/pull/2818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2818: apps/pwm_test: Fix configuration for nucleo boards
Posted by GitBox <gi...@apache.org>.
utzig commented on PR #2818:
URL: https://github.com/apache/mynewt-core/pull/2818#issuecomment-1105408844
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### apps/pwm_test/src/main.c
<details>
```diff
@@ -26,22 +26,22 @@
#if MYNEWT_VAL(BSP_nucleo_f767zi)
# define PWM_TEST_CH_CFG_PIN MCU_AFIO_GPIO(LED_BLINK_PIN, 2)
-# define PWM_TEST_CH_CFG_INV false
+# define PWM_TEST_CH_CFG_INV false
# define PWM_TEST_CH_NUM 2
# define PWM_TEST_IRQ_PRIO 0
#elif MYNEWT_VAL(BSP_nucleo_f303re)
# define PWM_TEST_CH_CFG_PIN MCU_AFIO_GPIO(LED_BLINK_PIN, 1)
-# define PWM_TEST_CH_CFG_INV false
+# define PWM_TEST_CH_CFG_INV false
# define PWM_TEST_CH_NUM 0
# define PWM_TEST_IRQ_PRIO 0
#elif MYNEWT_VAL(BSP_nucleo_f303k8)
# define PWM_TEST_CH_CFG_PIN MCU_AFIO_GPIO(LED_BLINK_PIN, 1)
-# define PWM_TEST_CH_CFG_INV false
+# define PWM_TEST_CH_CFG_INV false
# define PWM_TEST_CH_NUM 1
# define PWM_TEST_IRQ_PRIO 0
#else
# define PWM_TEST_CH_CFG_PIN LED_BLINK_PIN
-# define PWM_TEST_CH_CFG_INV true
+# define PWM_TEST_CH_CFG_INV true
# define PWM_TEST_CH_NUM 0
# define PWM_TEST_IRQ_PRIO 3
#endif
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org