You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/31 13:30:28 UTC
[GitHub] [incubator-devlake] likyh opened a new issue, #3625: [Refactor][Module Name] Confusion in IntegrationsContext
likyh opened a new issue, #3625:
URL: https://github.com/apache/incubator-devlake/issues/3625
## What and why to refactor
[What are you trying to refactor? Why should it be refactored now?](https://github.com/apache/incubator-devlake/blob/c215d73fba30c1c0114ab5be871f15b3645d6a53/config-ui/src/store/integrations-context.jsx#L22-L24)
Here 3 vars defined but export as other name.
https://github.com/apache/incubator-devlake/blob/c215d73fba30c1c0114ab5be871f15b3645d6a53/config-ui/src/store/integrations-context.jsx#L51-L54
## Describe the solution you'd like
Change to the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3625: [Refactor][config-ui] Confusion in IntegrationsContext
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3625:
URL: https://github.com/apache/incubator-devlake/issues/3625#issuecomment-1297180253
@likyh Fixed w/ #3626.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3625: [Refactor][config-ui] Confusion in IntegrationsContext
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3625:
URL: https://github.com/apache/incubator-devlake/issues/3625#issuecomment-1297160897
https://github.com/apache/incubator-devlake/blob/c215d73fba30c1c0114ab5be871f15b3645d6a53/config-ui/src/store/integrations-context.jsx#L21-L33
Yes, I think `React.createContext` is what this plugin is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh closed issue #3625: [Refactor][config-ui] Confusion in IntegrationsContext
Posted by GitBox <gi...@apache.org>.
likyh closed issue #3625: [Refactor][config-ui] Confusion in IntegrationsContext
URL: https://github.com/apache/incubator-devlake/issues/3625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3625: [Refactor][config-ui] Confusion in IntegrationsContext
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3625:
URL: https://github.com/apache/incubator-devlake/issues/3625#issuecomment-1297144889
@likyh I think I see the confusion you are referring to now, the initial context shape on `Ln 22-24` needs to be updated to Uppercase `Registry`, `Plugins` and `Integration`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3625: [Refactor][config-ui] Confusion in IntegrationsContext
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3625:
URL: https://github.com/apache/incubator-devlake/issues/3625#issuecomment-1297135794
@likyh These exports are aliased, it's not confusing... the context props are Capitalized intentionally to signify Priority (Integrations vs integrations. Please close this ticket. It's clearly indicated the props are aliased with the context value.
<img width="676" alt="Screen Shot 2022-10-31 at 9 58 55 AM" src="https://user-images.githubusercontent.com/1742233/199025514-5f18b495-4d75-4332-b4a3-b722bcdafe17.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org