You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by Serge Huber <sh...@jahia.com> on 2004/02/18 15:12:43 UTC
System.out.println left in the code ?
I had a quick look at the Pluto code today and I was wondering if it was
intentional that there were still two classes that contained
System.out.println statements :
org.apache.pluto.core.impl.RenderRequestImpl.getPreferences()
org.apache.pluto.portalImpl.Deploy
I've been following a bit on and off the discussion about logging, so my
excuses if this was intentional.
Regards,
Serge Huber.
- -- --- -----=[ shuber2 at jahia dot com ]=---- --- -- -
www.jahia.org : A collaborative source CMS and Portal Server
Re: System.out.println left in the code ?
Posted by Serge Huber <sh...@jahia.com>.
At 05:33 PM 2/18/2004, you wrote:
>Yes, they should be removed, thanks for catching it.
You're welcome... But it wasn't that hard :)
cheers,
Serge...
- -- --- -----=[ shuber2 at jahia dot com ]=---- --- -- -
www.jahia.org : A collaborative source CMS and Portal Server
Re: System.out.println left in the code ?
Posted by Stefan Hepper <st...@hursley.ibm.com>.
Yes, they should be removed, thanks for catching it.
Stefan
David H. DeWolf wrote:
> Serge Huber wrote:
>
>>
>> I had a quick look at the Pluto code today and I was wondering if it
>> was intentional that there were still two classes that contained
>> System.out.println statements :
>>
>> org.apache.pluto.core.impl.RenderRequestImpl.getPreferences()
>> org.apache.pluto.portalImpl.Deploy
>>
> Both of these appear to be remnants from the initial development of
> pluto. I would be in favor of modifying these instances (and any others
> that use System.out.println) to use the logging framework. I'll submit a
> patch for it in the near future.
>
>> I've been following a bit on and off the discussion about logging, so
>> my excuses if this was intentional.
>>
> I don't think that these have been mentioned at all in our logging
> discussions. My guess is that no one realized they were there.
>
>> Regards,
>> Serge Huber.
>>
> Good Catch!
>
> David
>
>>
>> - -- --- -----=[ shuber2 at jahia dot com ]=---- --- -- -
>> www.jahia.org : A collaborative source CMS and Portal Server
>>
>>
>
>
>
Re: System.out.println left in the code ?
Posted by "David H. DeWolf" <da...@vivare.com>.
Serge Huber wrote:
>
> I had a quick look at the Pluto code today and I was wondering if it
> was intentional that there were still two classes that contained
> System.out.println statements :
>
> org.apache.pluto.core.impl.RenderRequestImpl.getPreferences()
> org.apache.pluto.portalImpl.Deploy
>
Both of these appear to be remnants from the initial development of
pluto. I would be in favor of modifying these instances (and any others
that use System.out.println) to use the logging framework. I'll submit a
patch for it in the near future.
> I've been following a bit on and off the discussion about logging, so
> my excuses if this was intentional.
>
I don't think that these have been mentioned at all in our logging
discussions. My guess is that no one realized they were there.
> Regards,
> Serge Huber.
>
Good Catch!
David
>
> - -- --- -----=[ shuber2 at jahia dot com ]=---- --- -- -
> www.jahia.org : A collaborative source CMS and Portal Server
>
>