You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/24 14:13:13 UTC

[GitHub] [flink] libenchao commented on a change in pull request #13081: [FLINK-18590][json] Support json array explode to multi messages

libenchao commented on a change in pull request #13081:
URL: https://github.com/apache/flink/pull/13081#discussion_r511467564



##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -130,6 +133,39 @@ public RowData deserialize(byte[] message) throws IOException {
 		}
 	}
 
+	@Override

Review comment:
       I agree that we should remove this method for json format. However there are many places that still call this method. We can do this work in one separate issue, WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org