You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2016/10/13 20:00:58 UTC
[GitHub] trafficserver pull request #1107: TS-4967: Enable header_freq logging to a s...
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1107
TS-4967: Enable header_freq logging to a specific file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4967
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1107
----
commit 91f3a857c8b1c7887e8506d286277783773e6ecd
Author: Alan M. Carroll <so...@yahoo-inc.com>
Date: 2016-10-13T15:44:12Z
TS-4967: Enable header_freq logging to a specific file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1107: TS-4967: Enable header_freq logging to a s...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1107#discussion_r83305165
--- Diff: plugins/experimental/header_freq/header_freq.cc ---
@@ -46,18 +46,15 @@ static std::map<std::string, unsigned int> client_freq;
static std::map<std::string, unsigned int> origin_freq;
// for traffic_ctl, name is a convenient identifier
-static const char *ctl_tag = plugin_name;
-static const char *ctl_log = "log"; // log all data
+static const char *ctl_tag = plugin_name;
+static const char CONTROL_MSG_LOG[] = "log"; // log all data
+static const size_t CONTROL_MSG_LOG_LEN = sizeof(CONTROL_MSG_LOG) - 1;
--- End diff --
Might as well move everything into the anonymous namespace?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1107: TS-4967: Enable header_freq logging to a s...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1107#discussion_r83306042
--- Diff: plugins/experimental/header_freq/header_freq.cc ---
@@ -46,18 +46,15 @@ static std::map<std::string, unsigned int> client_freq;
static std::map<std::string, unsigned int> origin_freq;
// for traffic_ctl, name is a convenient identifier
-static const char *ctl_tag = plugin_name;
-static const char *ctl_log = "log"; // log all data
+static const char *ctl_tag = plugin_name;
+static const char CONTROL_MSG_LOG[] = "log"; // log all data
+static const size_t CONTROL_MSG_LOG_LEN = sizeof(CONTROL_MSG_LOG) - 1;
--- End diff --
Sure, why not?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1107: TS-4967: Enable header_freq logging to a specific...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1107
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1006/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1107: TS-4967: Enable header_freq logging to a specific...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1107
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1005/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1107: TS-4967: Enable header_freq logging to a s...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/1107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1107: TS-4967: Enable header_freq logging to a specific...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1107
Well, beyond that `TSTextLogObjectCreate` doesn't seem to be documented, it seems more work than is useful for a single write. Note that there's no guarantee multiple invocations will all use the same file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1107: TS-4967: Enable header_freq logging to a specific...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1107
I communicated with Petar about this as well and he's fine with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1107: TS-4967: Enable header_freq logging to a specific...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1107
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/897/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1107: TS-4967: Enable header_freq logging to a specific...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1107
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/898/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---