Re: svn commit: r472774 - in /incubator/ofbiz/trunk/applications/product: config/ entitydef/ script/org/ofbiz/product/subscription/ servicedef/ webapp/catalog/WEB-INF/ widget/catalog/

[David E Jones <jo...@undersunconsulting.com>]

On Nov 8, 2006, at 10:10 PM, hansbak@apache.org wrote:

> Modified: incubator/ofbiz/trunk/applications/product/entitydef/ 
> entitymodel.xml
> URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/ 
> applications/product/entitydef/entitymodel.xml? 
> view=diff&rev=472774&r1=472773&r2=472774
> ====================================================================== 
> ========
> --- incubator/ofbiz/trunk/applications/product/entitydef/ 
> entitymodel.xml (original)
> +++ incubator/ofbiz/trunk/applications/product/entitydef/ 
> entitymodel.xml Wed Nov  8 21:10:56 2006
> @@ -3616,7 +3616,7 @@
>      <entity entity-name="Subscription" package- 
> name="org.ofbiz.product.subscription" title="Subscription Entity">
>          <field name="subscriptionId" type="id-ne"></field>
>          <field name="subscriptionResourceId" type="id"></field>
> -        <field name="communicationEventId" type="id"></field>
> +        <!--field name="communicationEventId" type="id"></field-- 
> ><!-- now replaced by entity: SubscriptionCommEvent -->
>          <field name="contactMechId" type="id"></field>
>          <field name="originatedFromPartyId" type="id"></field>
>          <field name="originatedFromRoleTypeId" type="id"></field>

Removing this seems a little risky to me and without services to  
migrate the field for existing data it's also a real pain. Have you  
reviewed this for these impacts and the use of this field in other  
parts of the code?

I'm also wondering why removing this is important as it's not a big  
deal to have this in place along with the new stuff.

-David