You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/12/13 22:03:03 UTC
[GitHub] [hbase] joshelser edited a comment on pull request #3941: HBASE-26557 Correct export to set log4j2.formatMsgNoLookups in HBASE_…
joshelser edited a comment on pull request #3941:
URL: https://github.com/apache/hbase/pull/3941#issuecomment-992940447
Great question. I just ran it through their online interpreter for shell check and it should have generated an error.
The nightly build doesn't seem to complain
```
23:25:33 ============================================================================
23:25:33 ============================================================================
23:25:33 shellcheck plugin: full
23:25:33 ============================================================================
23:25:33 ============================================================================
23:25:33
23:25:33
23:25:33 Running shellcheck against all suspected shell scripts
23:25:33 /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh: line 118: warning: command substitution: ignored null byte in input
23:25:33 /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh: line 118: warning: command substitution: ignored null byte in input
23:25:33 /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh: line 118: warning: command substitution: ignored null byte in input
```
The nightly doesn't seem to think anything is wrong with it. The shellcheck specific output doesn't even mention hbase-config.sh.
https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/465/artifact/output-general/ meant to add this the first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org