You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sdap.apache.org by "RKuttruff (via GitHub)" <gi...@apache.org> on 2023/03/08 22:15:55 UTC

[GitHub] [incubator-sdap-nexus] RKuttruff opened a new pull request, #234: SDAP-444 - Fixed resultSizeLimit truncating result storage in match_spark

RKuttruff opened a new pull request, #234:
URL: https://github.com/apache/incubator-sdap-nexus/pull/234

   To my understanding, resultSizeLimit should only limit the results that are returned to the user for the match_spark query, but it can also truncate the results that are stored to be fetched by the results endpoint.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-sdap-nexus] RKuttruff merged pull request #234: SDAP-444 - Fixed resultSizeLimit truncating result storage in match_spark

Posted by "RKuttruff (via GitHub)" <gi...@apache.org>.
RKuttruff merged PR #234:
URL: https://github.com/apache/incubator-sdap-nexus/pull/234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-sdap-nexus] RKuttruff commented on pull request #234: SDAP-444 - Fixed resultSizeLimit truncating result storage in match_spark

Posted by "RKuttruff (via GitHub)" <gi...@apache.org>.
RKuttruff commented on PR #234:
URL: https://github.com/apache/incubator-sdap-nexus/pull/234#issuecomment-1492259796

   > I think we should ask the team if this is the desired behavior. If they limit the size of the result, would they also want to limit the size of the CSV/NetCDF result? I'm not aware of any way to limit the size of the result from the /cdmsresults endpoint. 
   
   IMO, if we do the computation for a matchup, it makes sense that we'd want to store the whole matchup. 
   Adding size limits to the results endpoint will be trivial.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org