You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/12/15 23:24:47 UTC
Review Request 41412: RANGER-784: Annotate REST API classes to use
get/set methods during serialization/deserialization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41412/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-784
https://issues.apache.org/jira/browse/RANGER-784
Repository: ranger
Description
-------
Updated annotation on classes used in REST API, to use set/get methods instead of directly accessing the fields.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java eac8be8
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java 5b7cd11
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java 85bfec6
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java 867920f
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTag.java a57f986
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagDef.java 93f7b14
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagResourceMap.java ada2b8d
Diff: https://reviews.apache.org/r/41412/diff/
Testing
-------
Verified that with the updated annotations, Ranger admin is able to treat missing fields/null values fields gracefully.
Thanks,
Madhan Neethiraj
Re: Review Request 41412: RANGER-784: Annotate REST API classes to use
get/set methods during serialization/deserialization
Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41412/#review110583
-----------------------------------------------------------
Ship it!
Ship It!
- Selvamohan Neethiraj
On Dec. 15, 2015, 5:24 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41412/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 5:24 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-784
> https://issues.apache.org/jira/browse/RANGER-784
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Updated annotation on classes used in REST API, to use set/get methods instead of directly accessing the fields.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java eac8be8
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java 5b7cd11
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java 85bfec6
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java 867920f
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTag.java a57f986
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagDef.java 93f7b14
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagResourceMap.java ada2b8d
>
> Diff: https://reviews.apache.org/r/41412/diff/
>
>
> Testing
> -------
>
> Verified that with the updated annotations, Ranger admin is able to treat missing fields/null values fields gracefully.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>