You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:02:26 UTC
[GitHub] [james-project] chibenwa opened a new pull request, #1225: JAMES-3816 Manage IMAP throttling errors
chibenwa opened a new pull request, #1225:
URL: https://github.com/apache/james-project/pull/1225
Previously on rejected IMAP computation the connexion was closed which may be a bit too harsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1225: JAMES-3816 Manage IMAP throttling errors
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on code in PR #1225:
URL: https://github.com/apache/james-project/pull/1225#discussion_r985677110
##########
server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ReactiveThrottler.java:
##########
@@ -73,7 +81,7 @@ public Mono<Void> throttle(Publisher<Void> task) {
String.format(
"The IMAP server has reached its maximum capacity "
+ "(concurrent requests: %d, queue size: %d)",
- maxConcurrentRequests, maxQueueSize)));
+ maxConcurrentRequests, maxQueueSize), imapMessage));
Review Comment:
Missing `%s` for imapMessage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1225: JAMES-3816 Manage IMAP throttling errors
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1225:
URL: https://github.com/apache/james-project/pull/1225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1225: JAMES-3816 Manage IMAP throttling errors
Posted by GitBox <gi...@apache.org>.
chibenwa commented on code in PR #1225:
URL: https://github.com/apache/james-project/pull/1225#discussion_r985679448
##########
server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ReactiveThrottler.java:
##########
@@ -73,7 +81,7 @@ public Mono<Void> throttle(Publisher<Void> task) {
String.format(
"The IMAP server has reached its maximum capacity "
+ "(concurrent requests: %d, queue size: %d)",
- maxConcurrentRequests, maxQueueSize)));
+ maxConcurrentRequests, maxQueueSize), imapMessage));
Review Comment:
No it's not, it's a parameter to the exception, not the string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org