You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/12/20 19:41:19 UTC

[GitHub] [netbeans] matthiasblaesing commented on issue #1799: [NETBEANS-3615] - enum is now a keyword and not an identifier

matthiasblaesing commented on issue #1799: [NETBEANS-3615] - enum is now a keyword and not an identifier
URL: https://github.com/apache/netbeans/pull/1799#issuecomment-568061934
 
 
   I'm inclined to leave the module as is - someone was there before us - from the `build.xml`:
   
   ```
       <!-- ... -->
       <available property="is.jdk9" classname="java.lang.Module"/>
       <import file="../../nbbuild/templates/projectized.xml"/>
   
       <target name="compile" depends="-copy" unless="is.jdk9">
           <antcall target="projectized-common.compile"/>
       </target>
       <!-- ... -->
   ```
   
   This translates to: "If the build is run on JDK 9 and newer, just skip this module." The moment we drop build support for JDK8, the module will be gone. We could drop it now, but do we gain anything?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists