You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2025/08/08 07:29:03 UTC

svn commit: r1927679 - pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf

Author: tilman
Date: Fri Aug  8 07:29:03 2025
New Revision: 1927679

Log:
PDFBOX-6049: refactor

Modified:
   pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java	Fri Aug  8 06:45:02 2025	(r1927678)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java	Fri Aug  8 07:29:03 2025	(r1927679)
@@ -454,8 +454,9 @@ public class Overlay implements Closeabl
             resources = new PDResources();
             page.setResources(resources);
         }
-        COSName xObjectId = createOverlayXObject(page, layoutPage);
-        array.add(createOverlayStream(page, layoutPage, xObjectId));
+        PDFormXObject overlayFormXObject = createOverlayFormXObject(layoutPage);
+        COSName formXObjectId = resources.add(overlayFormXObject, "OL");
+        array.add(createOverlayStream(page, layoutPage, formXObjectId));
     }
 
     private LayoutPage getLayoutPage(int pageNumber, int numberOfPages)
@@ -493,7 +494,7 @@ public class Overlay implements Closeabl
         return layoutPage;
     }
 
-    private COSName createOverlayXObject(PDPage page, LayoutPage layoutPage)
+    private PDFormXObject createOverlayFormXObject(LayoutPage layoutPage)
     {
         PDFormXObject xobjForm = new PDFormXObject(layoutPage.overlayContentStream);
         xobjForm.setResources(new PDResources(layoutPage.overlayResources));
@@ -518,8 +519,7 @@ public class Overlay implements Closeabl
                 break;
         }
         xobjForm.setMatrix(at);
-        PDResources resources = page.getResources();
-        return resources.add(xobjForm, "OL");
+        return xobjForm;
     }
 
     private COSStream createOverlayStream(PDPage page, LayoutPage layoutPage, COSName xObjectId)