[GitHub] [iceberg] stevenzwu edited a comment on pull request #1956: upgrade flink version from 1.11.0 to 1.12.0

[GitBox <gi...@apache.org>]

stevenzwu edited a comment on pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#issuecomment-749717064


   @openinx I totally agree that we shouldn't upgrade flink to 1.12.0 until Iceberg 0.11.0 is released. 
   
   Regarding this PR, this is still some problem with the test failures `Trying to access closed classloader`. I tried to follow the same approach from what @JingsongLi did with [FLINK-19843]((https://issues.apache.org/jira/browse/FLINK-19843)). Still wasn't able to fix it yet.
   
   ```
   StdErr java.lang.IllegalStateException: Trying to access closed classloader. Please check if you store classloaders directly or indirectly in static fields. If the stacktrace suggests that the leak occurs in a third party library and cannot be fixed immediately, you can disable this check with the configuration 'classloader.check-leaked-classloader'.
   StdErr  at org.apache.flink.runtime.execution.librarycache.FlinkUserCodeClassLoaders$SafetyNetWrapperClassLoader.ensureInner(FlinkUserCodeClassLoaders.java:161)
   StdErr  at org.apache.flink.runtime.execution.librarycache.FlinkUserCodeClassLoaders$SafetyNetWrapperClassLoader.loadClass(FlinkUserCodeClassLoaders.java:168)
   StdErr  at java.base/java.lang.Class.forName0(Native Method)
   StdErr  at java.base/java.lang.Class.forName(Class.java:398)
   StdErr  at org.apache.iceberg.common.DynClasses$Builder.impl(DynClasses.java:68)
   StdErr  at org.apache.iceberg.avro.GenericAvroReader$ReadBuilder.record(GenericAvroReader.java:85)
   StdErr  at org.apache.iceberg.avro.GenericAvroReader$ReadBuilder.record(GenericAvroReader.java:72)
   StdErr  at org.apache.iceberg.avro.AvroSchemaVisitor.visit(AvroSchemaVisitor.java:50)
   StdErr  at org.apache.iceberg.avro.GenericAvroReader.initReader(GenericAvroReader.java:47)
   StdErr  at org.apache.iceberg.avro.GenericAvroReader.setSchema(GenericAvroReader.java:53)
   StdErr  at org.apache.iceberg.avro.ProjectionDatumReader.newDatumReader(ProjectionDatumReader.java:80)
   StdErr  at org.apache.iceberg.avro.ProjectionDatumReader.setSchema(ProjectionDatumReader.java:69)
   StdErr  at org.apache.avro.file.DataFileStream.initialize(DataFileStream.java:132)
   StdErr  at org.apache.avro.file.DataFileReader.<init>(DataFileReader.java:106)
   StdErr  at org.apache.avro.file.DataFileReader.<init>(DataFileReader.java:98)
   StdErr  at org.apache.avro.file.DataFileReader.openReader(DataFileReader.java:66)
   StdErr  at org.apache.iceberg.avro.AvroIterable.newFileReader(AvroIterable.java:100)
   StdErr  at org.apache.iceberg.avro.AvroIterable.getMetadata(AvroIterable.java:66)
   StdErr  at org.apache.iceberg.ManifestReader.<init>(ManifestReader.java:101)
   StdErr  at org.apache.iceberg.ManifestFiles.read(ManifestFiles.java:87)
   StdErr  at org.apache.iceberg.ManifestFiles.open(ManifestFiles.java:192)
   StdErr  at org.apache.iceberg.ManifestFiles.open(ManifestFiles.java:185)
   StdErr  at org.apache.iceberg.CatalogUtil.lambda$deleteFiles$4(CatalogUtil.java:106)
   StdErr  at org.apache.iceberg.util.Tasks$Builder.runTaskWithRetry(Tasks.java:404)
   StdErr  at org.apache.iceberg.util.Tasks$Builder.access$300(Tasks.java:70)
   StdErr  at org.apache.iceberg.util.Tasks$Builder$1.run(Tasks.java:310)
   StdErr  at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
   StdErr  at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
   StdErr  at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
   StdErr  at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
   StdErr  at java.base/java.lang.Thread.run(Thread.java:834)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org