You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/26 17:44:25 UTC
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #15: test: add test cases about filter
tzssangglass opened a new pull request #15:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/15
1. add test cases about filter
2. fix bug about encode filter chain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] nic-chen commented on pull request #15: test: add test cases about filter
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #15:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/15#issuecomment-849486764
@dmsolr
Please help review, I am not familiar with the specific logic.
If there is OK, we could merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #15: test: add test cases about filter
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #15:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/15#discussion_r640417893
##########
File path: runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6ConfigHandler.java
##########
@@ -65,6 +64,10 @@ private PluginFilterChain createFilterChain(Req req) {
logger.error("receive undefined filter: {}, skip it", conf.name());
continue;
}
+ if (chainFilters.contains(filter)) {
+ logger.error("skip the same filter: {}", conf.name());
Review comment:
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #15: test: add test cases about filter
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #15:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/15#issuecomment-849251504
@dmsolr @spacewander pls review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander merged pull request #15: test: add test cases about filter
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #15:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] nic-chen commented on a change in pull request #15: test: add test cases about filter
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #15:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/15#discussion_r640411861
##########
File path: runner-core/src/main/java/org/apache/apisix/plugin/runner/handler/A6ConfigHandler.java
##########
@@ -65,6 +64,10 @@ private PluginFilterChain createFilterChain(Req req) {
logger.error("receive undefined filter: {}, skip it", conf.name());
continue;
}
+ if (chainFilters.contains(filter)) {
+ logger.error("skip the same filter: {}", conf.name());
Review comment:
could we use a lower level to log ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org