[GitHub] [doris] HappenLee commented on a diff in pull request #21668: [Fix](pipeline) Close sink during fragment context destruction

["HappenLee (via GitHub)" <gi...@apache.org>]

HappenLee commented on code in PR #21668:
URL: https://github.com/apache/doris/pull/21668#discussion_r1257821256


##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -707,6 +707,16 @@ Status PipelineFragmentContext::submit() {
     }
 }
 
+void PipelineFragmentContext::close_sink() {
+    if (_sink) {
+        if (_prepared) {
+            _sink->close(_runtime_state.get(), Status::RuntimeError("prepare failed"));
+        } else {
+            _sink->close(_runtime_state.get(), Status::OK());

Review Comment:
   maybe need dispose status of sink close?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org