You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/24 12:45:20 UTC
[jira] [Commented] (COUCHDB-3007) Navigating to 'Main config' fails
after visiting 'CORS'
[ https://issues.apache.org/jira/browse/COUCHDB-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391048#comment-15391048 ]
ASF GitHub Bot commented on COUCHDB-3007:
-----------------------------------------
GitHub user samk1 opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/750
Config section reactjs rewrite
This PR replicates all of the original functionality of the config section, with a few minor differences to the look and feel:
- only one option is editable at a time.
- option editing starts with a single click on the value cell.
- the entire cell is clickable.
- the option names are no longer editable. (this seems to have been a bug in the old code)
- hover styling added to table, to highlight which row is currently 'active'
- delete confirmation modal has been changed to the fauxton modal confirmation react component.
- notifications are fired when an option is created, saved or deleted (and when any of those actions fails).
- no suggestions are provided when entering a new section name - I intend to add this, I only noticed I didn't have this feature while I was creating this pull request.
Also, the route functions for both cors and config have been changed so that when cors is rendered it doesn't clobber the template where config is going to be rendered. This fixes COUCHDB-3007.
Full commit history is on my github under the 'my-config-reactjs-rewrite' branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samk1/couchdb-fauxton config-reactjs-rewrite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/750.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #750
----
commit c912f9bf7935f7e24279974add046d043ca5c11d
Author: samk <sa...@gmail.com>
Date: 2016-07-24T11:55:11Z
simplify resources
commit 39e0b48f3ae11d336d4a4e6734ba19cf3dc29f79
Author: samk <sa...@gmail.com>
Date: 2016-07-24T11:58:33Z
react.js functionality
commit 34b1b179e49d704e1ebacffc038de2c9ff761d05
Author: samk <sa...@gmail.com>
Date: 2016-07-24T11:59:22Z
style changes
commit b354d70794d4014bdae9f2a73ab95aa39bc739a9
Author: samk <sa...@gmail.com>
Date: 2016-07-24T12:00:10Z
new tests
commit 790c300dc5931bb6838b3639301a7882f73d8ec4
Author: samk <sa...@gmail.com>
Date: 2016-07-24T12:10:51Z
render new react components in route object
commit 17a3a919f738fc92b3e79ce289f83b6ade02e7a1
Author: samk <sa...@gmail.com>
Date: 2016-07-24T12:16:21Z
remove dead views and templates
commit fefa87dd7543afe2ba74631c88f533cf8c013642
Author: samk <sa...@gmail.com>
Date: 2016-07-24T12:18:30Z
license check
----
> Navigating to 'Main config' fails after visiting 'CORS'
> -------------------------------------------------------
>
> Key: COUCHDB-3007
> URL: https://issues.apache.org/jira/browse/COUCHDB-3007
> Project: CouchDB
> Issue Type: Bug
> Components: Fauxton
> Reporter: Mathis Wiehl
>
> If the user visits the 'CORS' section in the Configuration tab and clicks on 'Main config' the content of main content pane doesn't change.
> The interesting thing is though, that the '+ Add Option' button in the headerbar reappears when the 'Main config' button is clicked.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)