You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2017/11/28 22:05:42 UTC
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8670
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
IMPALA-6242: Reduce flakiness in TimerCounterTest
The error threshold in TimerCounterTest is 15ms, which is still not
enough in some rare cases. This patch increases it to 30ms.
Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
---
M be/src/util/runtime-profile-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/8670/1
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Dec 2017 00:22:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8670/2/be/src/util/runtime-profile-test.cc
File be/src/util/runtime-profile-test.cc:
http://gerrit.cloudera.org:8080/#/c/8670/2/be/src/util/runtime-profile-test.cc@630
PS2, Line 630: if (csw_.TotalRunningTime() > 6000000000) {
> Might need to update this check as well.
Done
http://gerrit.cloudera.org:8080/#/c/8670/2/be/src/util/runtime-profile-test.cc@631
PS2, Line 631: DCHECK(false);
> It wasn't introduced in this commit, but to my understanding EXPECT_FALSE(f
Done
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Dec 2017 01:29:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1603/
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Dec 2017 00:22:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8670
to look at the new patch set (#3).
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
IMPALA-6242: Reduce flakiness in TimerCounterTest
The error threshold in TimerCounterTest is 15ms, which is still not
enough in some rare cases. This patch increases it to 30ms.
Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
---
M be/src/util/runtime-profile-test.cc
1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/8670/3
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Dec 2017 03:58:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
IMPALA-6242: Reduce flakiness in TimerCounterTest
The error threshold in TimerCounterTest is 15ms, which is still not
enough in some rare cases. This patch increases it to 30ms.
Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
---
M be/src/util/runtime-profile-test.cc
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/8670/2
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
Patch Set 1:
Since we are measuring wall time here, I don't know any better.
I think 30 ms for measurement error is still acceptable, but maybe you could increase the sleep times as well to keep the measurement error a small fraction of the measured runtime.
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Dec 2017 16:37:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
IMPALA-6242: Reduce flakiness in TimerCounterTest
The error threshold in TimerCounterTest is 15ms, which is still not
enough in some rare cases. This patch increases it to 30ms.
Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Reviewed-on: http://gerrit.cloudera.org:8080/8670
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/util/runtime-profile-test.cc
1 file changed, 16 insertions(+), 16 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8670/2/be/src/util/runtime-profile-test.cc
File be/src/util/runtime-profile-test.cc:
http://gerrit.cloudera.org:8080/#/c/8670/2/be/src/util/runtime-profile-test.cc@630
PS2, Line 630: if (csw_.TotalRunningTime() > 3000000000) {
Might need to update this check as well.
http://gerrit.cloudera.org:8080/#/c/8670/2/be/src/util/runtime-profile-test.cc@631
PS2, Line 631: EXPECT_FALSE(false);
It wasn't introduced in this commit, but to my understanding EXPECT_FALSE(false) is a no-op, it doesn't fail the test.
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Dec 2017 10:18:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8670/3/be/src/util/runtime-profile-test.cc
File be/src/util/runtime-profile-test.cc:
http://gerrit.cloudera.org:8080/#/c/8670/3/be/src/util/runtime-profile-test.cc@631
PS3, Line 631: DCHECK
We should use EXPECT_TRUE. DCHECK crashes the process and is also removed in release builds.
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Dec 2017 16:33:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
Patch Set 3: Code-Review+1
Thanks for applying the changes. Seems OK to me.
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Dec 2017 09:18:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6242: Reduce flakiness in TimerCounterTest
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest
......................................................................
IMPALA-6242: Reduce flakiness in TimerCounterTest
The error threshold in TimerCounterTest is 15ms, which is still not
enough in some rare cases. This patch increases it to 30ms.
Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
---
M be/src/util/runtime-profile-test.cc
1 file changed, 16 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/8670/4
--
To view, visit http://gerrit.cloudera.org:8080/8670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412
Gerrit-Change-Number: 8670
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>