You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sarathkouk <gi...@git.apache.org> on 2016/01/28 10:55:59 UTC

[GitHub] cloudstack pull request: Escalation Automation of bug CS-43976 :VM...

GitHub user sarathkouk opened a pull request:

    https://github.com/apache/cloudstack/pull/1377

     Escalation Automation of bug CS-43976 :VM snapshot fails for 12 min …

    …after instance creation
    
    ISSUE
    ============
    VM snapshot fails for 12 min after instance creation
    
    EXPECTED BEHAVIOR
    ==================
    VMSnapshot should be successful from the moment the VM is ready

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarathkouk/cloudstack escalation2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1377
    
----
commit 8db4806cfa142adf66e7e6ed79b7929f4ceefe12
Author: sharath <sh...@gmail.com>
Date:   2016-01-28T09:49:27Z

     Escalation Automation of bug CS-43976 :VM snapshot fails for 12 min after instance creation
    
    ISSUE
    ============
    VM snapshot fails for 12 min after instance creation
    
    EXPECTED BEHAVIOR
    ==================
    VMSnapshot should be successful from the moment the VM is ready

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1377#discussion_r51681502
  
    --- Diff: test/integration/component/test_escalations_snapshots.py ---
    @@ -639,3 +671,47 @@ def test_04_list_vm_snapshots_byid(self):
                              "Listed VM Snapshot details are not as expected"
                              )
             return
    +
    +    @attr(tags=["advanced", "basic"], required_hardware="true")
    +    def test_05_check_vm_snapshot_creation_after_Instance_creation(self):
    +        """
    +        @summary: Test  if SS creation is successful in the first
    +        10 minutes of VM deployment
    +
    +        Step1: Create a VM with any Service offering
    +        Step2: Create a VM snapshot
    +        Step3: Verify if SS creation is successful within first
    +               10 minutes of VM deployment
    +        """
    +        if self.hypervisor.lower() not in ['vmware']:
    +            raise unittest.SkipTest("This test case is only for vmware. Hence, skipping the test")
    +
    +        api_client = self.testClient.getUserApiClient(
    +                UserName=self.account.name,
    +                DomainName=self.account.domain)
    +
    +        vm = self.createInstance(service_off=self.service_offering, api_client=api_client)
    +        start_time = time.time()
    +
    +
    +        snapshot_created_1 = VmSnapshot.create(
    +                                                 self.userapiclient,
    +                                                 vm.id
    +                                                 )
    +        self.assertIsNotNone(
    +                                snapshot_created_1,
    +                                "Snapshot creation failed"
    +                                 )
    +
    +        time_elapsed = time.time()-start_time
    +
    +        self.assertTrue(
    +                        time_elapsed < 600,
    +                        "Snapshot did not get created in the first 10 minutes after VM creation"
    +                        )
    +
    --- End diff --
    
    Remove all the white spaces


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Escalation Automation of bug CS-43976 :VM...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1377#issuecomment-176095546
  
    @sarathkouk please remove the internal bug reference and replace it by an apache equivalent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1377#discussion_r51681219
  
    --- Diff: test/integration/component/test_escalations_snapshots.py ---
    @@ -639,3 +671,47 @@ def test_04_list_vm_snapshots_byid(self):
                              "Listed VM Snapshot details are not as expected"
                              )
             return
    +
    +    @attr(tags=["advanced", "basic"], required_hardware="true")
    +    def test_05_check_vm_snapshot_creation_after_Instance_creation(self):
    +        """
    +        @summary: Test  if SS creation is successful in the first
    +        10 minutes of VM deployment
    +
    +        Step1: Create a VM with any Service offering
    +        Step2: Create a VM snapshot
    +        Step3: Verify if SS creation is successful within first
    +               10 minutes of VM deployment
    +        """
    +        if self.hypervisor.lower() not in ['vmware']:
    +            raise unittest.SkipTest("This test case is only for vmware. Hence, skipping the test")
    --- End diff --
    
    Can you replace with skipTest  to avoid raising an exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Escalation Automation of bug CS-43976 :VM...

Posted by sarathkouk <gi...@git.apache.org>.
Github user sarathkouk commented on the pull request:

    https://github.com/apache/cloudstack/pull/1377#issuecomment-176095486
  
    TEST RESULT :  
    @summary: Test  if SS creation is successful in the first ... === TestName: test_05_check_vm_snapshot_creation_after_Instance_creation | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 305.719s
    
    OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:

    https://github.com/apache/cloudstack/pull/1377#issuecomment-197828321
  
    ### ACS CI BVT Run
     **Sumarry:**
     Build Number 106
     Hypervisor xenserver
     NetworkType Advanced
     Passed=104
     Failed=14
     Skipped=4
    
    **The follwing tests have known issues**
    test_vpc_remote_access_vpn
    test_vpc_site2site_vpn
    test_01_test_vm_volume_snapshot
    test_02_vpc_privategw_static_routes
    test_03_rvpc_privategw_static_routes
    test_04_change_offering_small
    ContextSuite context=TestNiciraContoller>:setup
    test_01_primary_storage_iscsi
    test02_internallb_haproxy_stats_on_all_interfaces
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
    ContextSuite context=TestDeployVM>:setup
    test_04_extract_template
    test_04_extract_Iso
    test_07_list_default_iso
    
    
    _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
    
    
    **Failed tests:**
    * integration.smoke.test_privategw_acl.TestPrivateGwACL
    
     * test_01_vpc_privategw_acl Failing since 2 runs
    
    * integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
    
     * test_dedicateGuestVlanRange Failing since 6 runs
    
    
    **Skipped tests:**
    test_vm_nic_adapter_vmxnet3
    test_deploy_vgpu_enabled_vm
    test_06_copy_template
    test_06_copy_iso
    
    **Passed test suits:**
    integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
    integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
    integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
    integration.smoke.test_over_provisioning.TestUpdateOverProvision
    integration.smoke.test_global_settings.TestUpdateConfigWithScope
    integration.smoke.test_scale_vm.TestScaleVm
    integration.smoke.test_service_offerings.TestCreateServiceOffering
    integration.smoke.test_loadbalance.TestLoadBalance
    integration.smoke.test_routers.TestRouterServices
    integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
    integration.smoke.test_snapshots.TestSnapshotRootDisk
    integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
    integration.smoke.test_network.TestDeleteAccount
    integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
    integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
    integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
    integration.smoke.test_multipleips_per_nic.TestDeployVM
    integration.smoke.test_regions.TestRegions
    integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
    integration.smoke.test_network_acl.TestNetworkACL
    integration.smoke.test_pvlan.TestPVLAN
    integration.smoke.test_volumes.TestCreateVolume
    integration.smoke.test_ssvm.TestSSVMs
    integration.smoke.test_nic.TestNic
    integration.smoke.test_deploy_vm_root_resize.TestDeployVM
    integration.smoke.test_resource_detail.TestResourceDetail
    integration.smoke.test_secondary_storage.TestSecStorageServices
    integration.smoke.test_vm_life_cycle.TestDeployVM
    integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1377#discussion_r51680970
  
    --- Diff: test/integration/component/test_escalations_snapshots.py ---
    @@ -152,6 +156,34 @@ def __verify_values(self, expected_vals, actual_vals):
                                                                                               ))
             return return_flag
     
    +    def createInstance(self, service_off, networks=None, api_client=None):
    +        """Creates an instance in account"""
    +
    +        if api_client is None:
    +            api_client = self.apiclient
    +
    +        self.debug("Deploying an instance in account: %s" %
    +                       self.account.name)
    +        try:
    +            vm = VirtualMachine.create(
    +                 api_client,
    +                 self.services["virtual_machine"],
    +                 templateid=self.template.id,
    +                 accountid=self.account.name,
    +                 domainid=self.account.domainid,
    +                 networkids=networks,
    +                 serviceofferingid=service_off.id)
    +            vms = VirtualMachine.list(api_client, id=vm.id, listall=True)
    +            self.assertIsInstance(vms,
    --- End diff --
    
    replace with validateList


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8830 : VM snapshot creation fa...

Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:

    https://github.com/apache/cloudstack/pull/1377#issuecomment-188173843
  
    this is redundant case , and checking time to create vmsnapshot is not required for this bug.
    I have talked to @sarathkouk , he understood the issue and agreed to modify the PR to CATH this specific bug.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---