[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #2834: InList: set/list value must be evaluated to get the values

[GitBox <gi...@apache.org>]

liukun4515 commented on code in PR #2834:
URL: https://github.com/apache/arrow-datafusion/pull/2834#discussion_r913453698


##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -270,37 +270,51 @@ fn not_in_list_utf8<OffsetSize: OffsetSizeTrait>(
 }
 
 //check all filter values of In clause are static.
-//include `CastExpr + Literal` or `Literal`
+//include `TryCastExpr/CastExpr + Literal` or `Literal`
 fn check_all_static_filter_expr(list: &[Arc<dyn PhysicalExpr>]) -> bool {
+    // TODO optimize the checker for constant in datafusion

Review Comment:
   for datafusion, we need to add interface which is used to identify the expr is constant or  literal or not.
   If we have this interface, we can make more optimization.
   But the interface should be better in the logical expr not in the physical expr like sprak `fold`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org