You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 15:21:42 UTC

[GitHub] [arrow] amol- commented on pull request #10199: ARROW-12431: [C++] Mask is inverted when creating FixedSizeBinaryArray

amol- commented on pull request #10199:
URL: https://github.com/apache/arrow/pull/10199#issuecomment-832776765


   > Not necessarily related to this PR (just noticed while looking at the code and testing a few things), but the conversion for fixed size binary is currently (on master) incorrect for the strided case:
   > 
   
   Good that you pointed that out, because I just added a test for that case and it fails (differently) also with my changes in place. Throws a
   ```
   NumPy type not implemented: unrecognized type (18) in GetNumPyTypeName
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org