You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Mark Grover (JIRA)" <ji...@apache.org> on 2013/01/04 16:04:16 UTC
[jira] [Updated] (HIVE-3858) Normalize left over CRLF files
[ https://issues.apache.org/jira/browse/HIVE-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Grover updated HIVE-3858:
------------------------------
Status: Patch Available (was: Open)
Fairly cosmetic change, changing CRLF to LF for 10 files.
> Normalize left over CRLF files
> ------------------------------
>
> Key: HIVE-3858
> URL: https://issues.apache.org/jira/browse/HIVE-3858
> Project: Hive
> Issue Type: Bug
> Reporter: Mark Grover
> Assignee: Mark Grover
> Attachments: HIVE-3858.1.patch
>
>
> There are 10 files which seem to have CRLF endings in the Hive repo right now. This becomes visible when using Mac OS X and cloning Hive's git repository.
> HIVE-3839 introduced a new .gitattributes file which will make sure that going forward no code containing CRLF gets checked-in going forward. However, I am not sure if we took care of existing code that already contains CRLF.
> In Hadoop, HADOOP-8912 introduced the .gitattributes file but HADOOP-8911 normalized existing files to get rid of their CRLF endings. I can't find a similar check-in in Hive before we commited HIVE-3839.
> But that's ok, it's not too late. This check-in will normalize any files in Hive that presently have one or more CRLF endings.
> The following are the 10 files I could find:
> {code}
> # modified: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java
> # modified: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionObjectInspector.java
> # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ListTypeInfo.java
> # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/MapTypeInfo.java
> # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java
> # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/StructTypeInfo.java
> # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java
> # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
> # modified: serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
> # modified: serde/src/test/org/apache/hadoop/hive/serde2/thrift_test/CreateSequenceFile.java
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira