You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Chetan Khatri <ch...@gmail.com> on 2017/01/25 19:34:02 UTC
Git Pull Request to HBase
Hello ,
I have been submitted 3 PR to HBase Git Repository, I think it is not what
HBase Community expect, I need to submit Patch as attachment to HBase JIRA.
Can anybody give me steps for the same.
Thanks.
Re: Git Pull Request to HBase
Posted by Apekshit Sharma <ap...@cloudera.com>.
Thanks Ted. That should make our new contributor Chetan happy :)
On Thu, Jan 26, 2017 at 11:59 AM, Ted Yu <yu...@gmail.com> wrote:
> The first commit carried Chetan's name in the commit message.
>
> Anyway I reverted and re-committed using 'git am'
>
> FYI
>
> On Thu, Jan 26, 2017 at 11:47 AM, Apekshit Sharma <ap...@cloudera.com>
> wrote:
>
> > Hi Chetan, Ted
> >
> > It's the right question to ask. One who does the work should get the
> > credits, and that means commit authorship too.
> > That's where the script submit_patch.py which i wrote a while back helps
> > too. If contributors use the script to submit formatted patch (instead of
> > just git diff and uploading raw patch), it makes sure that author field
> is
> > set correctly. So when a committer commits the patch 'in the right way',
> > original author gets the credit.
> >
> > In this case however, i think Ted forgot to use git am, which made him
> the
> > author on commit.
> >
> > @Ted: Please revert the old commit and use git am so that Chetan is
> > credited correctly.
> >
> > Thanks
> > Appy
> >
> >
> >
> > On Thu, Jan 26, 2017 at 11:31 AM, Chetan Khatri <
> > chetan.opensource@gmail.com
> > > wrote:
> >
> > > Hello Ted,
> > >
> > > I have quick question, if Apache HBase community don't follow Github PR
> > at
> > > all, but only JIRA Patch process. Then how contributors commit named
> with
> > > himself.
> > >
> > > For example, I have submitted 3 patches for 3 issues
> > >
> > > https://issues.apache.org/jira/browse/HBASE-17546
> > > https://issues.apache.org/jira/browse/HBASE-17547
> > > https://issues.apache.org/jira/browse/HBASE-17549 --Resolved.
> > >
> > > Now Resolved will get committed to master branch. Do committer has to
> do
> > > anything ? or else How committers name added to contributor ?
> > >
> > > Just for my information, I dont know.
> > >
> > > Thanks.
> > >
> > >
> > > On Thu, Jan 26, 2017 at 9:09 PM, Ted Yu <yu...@gmail.com> wrote:
> > >
> > > > Chetan:
> > > > I took a look at your patch.
> > > >
> > > > Reminder: currently tests in hbase-spark module wouldn't be run by
> QA.
> > > > See HBASE-16845
> > > >
> > > > Please run "mvn verify" manually
> > > >
> > > > Cheers
> > > >
> > > > On Thu, Jan 26, 2017 at 7:16 AM, Chetan Khatri <
> > > > chetan.opensource@gmail.com>
> > > > wrote:
> > > >
> > > > > Hello York,
> > > > >
> > > > > I think i followed the process :
> > > > > https://issues.apache.org/jira/browse/HBASE-17546
> > > > > Now i have to anything else ? or that's it
> > > > >
> > > > > Thanks.
> > > > >
> > > > > On Thu, Jan 26, 2017 at 1:09 AM, York, Zach <zy...@amazon.com>
> > wrote:
> > > > >
> > > > > > I would recommend you use the dev-support/submit-patch.py script
> to
> > > > > create
> > > > > > your patch.
> > > > > >
> > > > > > Information can be found here: http://hbase.apache.org/book.
> > > > > > html#submitting.patches.create
> > > > > >
> > > > > > Thanks,
> > > > > > Zach
> > > > > >
> > > > > > On 1/25/17, 11:34 AM, "Chetan Khatri" <
> chetan.opensource@gmail.com
> > >
> > > > > wrote:
> > > > > >
> > > > > > Hello ,
> > > > > >
> > > > > > I have been submitted 3 PR to HBase Git Repository, I think
> it
> > is
> > > > not
> > > > > > what
> > > > > > HBase Community expect, I need to submit Patch as attachment
> to
> > > > HBase
> > > > > > JIRA.
> > > > > >
> > > > > > Can anybody give me steps for the same.
> > > > > >
> > > > > >
> > > > > > Thanks.
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> >
> > -- Appy
> >
>
--
-- Appy
Re: Git Pull Request to HBase
Posted by Ted Yu <yu...@gmail.com>.
The first commit carried Chetan's name in the commit message.
Anyway I reverted and re-committed using 'git am'
FYI
On Thu, Jan 26, 2017 at 11:47 AM, Apekshit Sharma <ap...@cloudera.com> wrote:
> Hi Chetan, Ted
>
> It's the right question to ask. One who does the work should get the
> credits, and that means commit authorship too.
> That's where the script submit_patch.py which i wrote a while back helps
> too. If contributors use the script to submit formatted patch (instead of
> just git diff and uploading raw patch), it makes sure that author field is
> set correctly. So when a committer commits the patch 'in the right way',
> original author gets the credit.
>
> In this case however, i think Ted forgot to use git am, which made him the
> author on commit.
>
> @Ted: Please revert the old commit and use git am so that Chetan is
> credited correctly.
>
> Thanks
> Appy
>
>
>
> On Thu, Jan 26, 2017 at 11:31 AM, Chetan Khatri <
> chetan.opensource@gmail.com
> > wrote:
>
> > Hello Ted,
> >
> > I have quick question, if Apache HBase community don't follow Github PR
> at
> > all, but only JIRA Patch process. Then how contributors commit named with
> > himself.
> >
> > For example, I have submitted 3 patches for 3 issues
> >
> > https://issues.apache.org/jira/browse/HBASE-17546
> > https://issues.apache.org/jira/browse/HBASE-17547
> > https://issues.apache.org/jira/browse/HBASE-17549 --Resolved.
> >
> > Now Resolved will get committed to master branch. Do committer has to do
> > anything ? or else How committers name added to contributor ?
> >
> > Just for my information, I dont know.
> >
> > Thanks.
> >
> >
> > On Thu, Jan 26, 2017 at 9:09 PM, Ted Yu <yu...@gmail.com> wrote:
> >
> > > Chetan:
> > > I took a look at your patch.
> > >
> > > Reminder: currently tests in hbase-spark module wouldn't be run by QA.
> > > See HBASE-16845
> > >
> > > Please run "mvn verify" manually
> > >
> > > Cheers
> > >
> > > On Thu, Jan 26, 2017 at 7:16 AM, Chetan Khatri <
> > > chetan.opensource@gmail.com>
> > > wrote:
> > >
> > > > Hello York,
> > > >
> > > > I think i followed the process :
> > > > https://issues.apache.org/jira/browse/HBASE-17546
> > > > Now i have to anything else ? or that's it
> > > >
> > > > Thanks.
> > > >
> > > > On Thu, Jan 26, 2017 at 1:09 AM, York, Zach <zy...@amazon.com>
> wrote:
> > > >
> > > > > I would recommend you use the dev-support/submit-patch.py script to
> > > > create
> > > > > your patch.
> > > > >
> > > > > Information can be found here: http://hbase.apache.org/book.
> > > > > html#submitting.patches.create
> > > > >
> > > > > Thanks,
> > > > > Zach
> > > > >
> > > > > On 1/25/17, 11:34 AM, "Chetan Khatri" <chetan.opensource@gmail.com
> >
> > > > wrote:
> > > > >
> > > > > Hello ,
> > > > >
> > > > > I have been submitted 3 PR to HBase Git Repository, I think it
> is
> > > not
> > > > > what
> > > > > HBase Community expect, I need to submit Patch as attachment to
> > > HBase
> > > > > JIRA.
> > > > >
> > > > > Can anybody give me steps for the same.
> > > > >
> > > > >
> > > > > Thanks.
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
>
> -- Appy
>
Re: Git Pull Request to HBase
Posted by Apekshit Sharma <ap...@cloudera.com>.
Hi Chetan, Ted
It's the right question to ask. One who does the work should get the
credits, and that means commit authorship too.
That's where the script submit_patch.py which i wrote a while back helps
too. If contributors use the script to submit formatted patch (instead of
just git diff and uploading raw patch), it makes sure that author field is
set correctly. So when a committer commits the patch 'in the right way',
original author gets the credit.
In this case however, i think Ted forgot to use git am, which made him the
author on commit.
@Ted: Please revert the old commit and use git am so that Chetan is
credited correctly.
Thanks
Appy
On Thu, Jan 26, 2017 at 11:31 AM, Chetan Khatri <chetan.opensource@gmail.com
> wrote:
> Hello Ted,
>
> I have quick question, if Apache HBase community don't follow Github PR at
> all, but only JIRA Patch process. Then how contributors commit named with
> himself.
>
> For example, I have submitted 3 patches for 3 issues
>
> https://issues.apache.org/jira/browse/HBASE-17546
> https://issues.apache.org/jira/browse/HBASE-17547
> https://issues.apache.org/jira/browse/HBASE-17549 --Resolved.
>
> Now Resolved will get committed to master branch. Do committer has to do
> anything ? or else How committers name added to contributor ?
>
> Just for my information, I dont know.
>
> Thanks.
>
>
> On Thu, Jan 26, 2017 at 9:09 PM, Ted Yu <yu...@gmail.com> wrote:
>
> > Chetan:
> > I took a look at your patch.
> >
> > Reminder: currently tests in hbase-spark module wouldn't be run by QA.
> > See HBASE-16845
> >
> > Please run "mvn verify" manually
> >
> > Cheers
> >
> > On Thu, Jan 26, 2017 at 7:16 AM, Chetan Khatri <
> > chetan.opensource@gmail.com>
> > wrote:
> >
> > > Hello York,
> > >
> > > I think i followed the process :
> > > https://issues.apache.org/jira/browse/HBASE-17546
> > > Now i have to anything else ? or that's it
> > >
> > > Thanks.
> > >
> > > On Thu, Jan 26, 2017 at 1:09 AM, York, Zach <zy...@amazon.com> wrote:
> > >
> > > > I would recommend you use the dev-support/submit-patch.py script to
> > > create
> > > > your patch.
> > > >
> > > > Information can be found here: http://hbase.apache.org/book.
> > > > html#submitting.patches.create
> > > >
> > > > Thanks,
> > > > Zach
> > > >
> > > > On 1/25/17, 11:34 AM, "Chetan Khatri" <ch...@gmail.com>
> > > wrote:
> > > >
> > > > Hello ,
> > > >
> > > > I have been submitted 3 PR to HBase Git Repository, I think it is
> > not
> > > > what
> > > > HBase Community expect, I need to submit Patch as attachment to
> > HBase
> > > > JIRA.
> > > >
> > > > Can anybody give me steps for the same.
> > > >
> > > >
> > > > Thanks.
> > > >
> > > >
> > > >
> > >
> >
>
--
-- Appy
Re: Git Pull Request to HBase
Posted by Chetan Khatri <ch...@gmail.com>.
Hello Ted,
I have quick question, if Apache HBase community don't follow Github PR at
all, but only JIRA Patch process. Then how contributors commit named with
himself.
For example, I have submitted 3 patches for 3 issues
https://issues.apache.org/jira/browse/HBASE-17546
https://issues.apache.org/jira/browse/HBASE-17547
https://issues.apache.org/jira/browse/HBASE-17549 --Resolved.
Now Resolved will get committed to master branch. Do committer has to do
anything ? or else How committers name added to contributor ?
Just for my information, I dont know.
Thanks.
On Thu, Jan 26, 2017 at 9:09 PM, Ted Yu <yu...@gmail.com> wrote:
> Chetan:
> I took a look at your patch.
>
> Reminder: currently tests in hbase-spark module wouldn't be run by QA.
> See HBASE-16845
>
> Please run "mvn verify" manually
>
> Cheers
>
> On Thu, Jan 26, 2017 at 7:16 AM, Chetan Khatri <
> chetan.opensource@gmail.com>
> wrote:
>
> > Hello York,
> >
> > I think i followed the process :
> > https://issues.apache.org/jira/browse/HBASE-17546
> > Now i have to anything else ? or that's it
> >
> > Thanks.
> >
> > On Thu, Jan 26, 2017 at 1:09 AM, York, Zach <zy...@amazon.com> wrote:
> >
> > > I would recommend you use the dev-support/submit-patch.py script to
> > create
> > > your patch.
> > >
> > > Information can be found here: http://hbase.apache.org/book.
> > > html#submitting.patches.create
> > >
> > > Thanks,
> > > Zach
> > >
> > > On 1/25/17, 11:34 AM, "Chetan Khatri" <ch...@gmail.com>
> > wrote:
> > >
> > > Hello ,
> > >
> > > I have been submitted 3 PR to HBase Git Repository, I think it is
> not
> > > what
> > > HBase Community expect, I need to submit Patch as attachment to
> HBase
> > > JIRA.
> > >
> > > Can anybody give me steps for the same.
> > >
> > >
> > > Thanks.
> > >
> > >
> > >
> >
>
Re: Git Pull Request to HBase
Posted by Ted Yu <yu...@gmail.com>.
Chetan:
I took a look at your patch.
Reminder: currently tests in hbase-spark module wouldn't be run by QA.
See HBASE-16845
Please run "mvn verify" manually
Cheers
On Thu, Jan 26, 2017 at 7:16 AM, Chetan Khatri <ch...@gmail.com>
wrote:
> Hello York,
>
> I think i followed the process :
> https://issues.apache.org/jira/browse/HBASE-17546
> Now i have to anything else ? or that's it
>
> Thanks.
>
> On Thu, Jan 26, 2017 at 1:09 AM, York, Zach <zy...@amazon.com> wrote:
>
> > I would recommend you use the dev-support/submit-patch.py script to
> create
> > your patch.
> >
> > Information can be found here: http://hbase.apache.org/book.
> > html#submitting.patches.create
> >
> > Thanks,
> > Zach
> >
> > On 1/25/17, 11:34 AM, "Chetan Khatri" <ch...@gmail.com>
> wrote:
> >
> > Hello ,
> >
> > I have been submitted 3 PR to HBase Git Repository, I think it is not
> > what
> > HBase Community expect, I need to submit Patch as attachment to HBase
> > JIRA.
> >
> > Can anybody give me steps for the same.
> >
> >
> > Thanks.
> >
> >
> >
>
Re: Git Pull Request to HBase
Posted by Chetan Khatri <ch...@gmail.com>.
Hello York,
I think i followed the process :
https://issues.apache.org/jira/browse/HBASE-17546
Now i have to anything else ? or that's it
Thanks.
On Thu, Jan 26, 2017 at 1:09 AM, York, Zach <zy...@amazon.com> wrote:
> I would recommend you use the dev-support/submit-patch.py script to create
> your patch.
>
> Information can be found here: http://hbase.apache.org/book.
> html#submitting.patches.create
>
> Thanks,
> Zach
>
> On 1/25/17, 11:34 AM, "Chetan Khatri" <ch...@gmail.com> wrote:
>
> Hello ,
>
> I have been submitted 3 PR to HBase Git Repository, I think it is not
> what
> HBase Community expect, I need to submit Patch as attachment to HBase
> JIRA.
>
> Can anybody give me steps for the same.
>
>
> Thanks.
>
>
>
Re: Git Pull Request to HBase
Posted by "York, Zach" <zy...@amazon.com>.
I would recommend you use the dev-support/submit-patch.py script to create your patch.
Information can be found here: http://hbase.apache.org/book.html#submitting.patches.create
Thanks,
Zach
On 1/25/17, 11:34 AM, "Chetan Khatri" <ch...@gmail.com> wrote:
Hello ,
I have been submitted 3 PR to HBase Git Repository, I think it is not what
HBase Community expect, I need to submit Patch as attachment to HBase JIRA.
Can anybody give me steps for the same.
Thanks.