You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jacktengg (via GitHub)" <gi...@apache.org> on 2024/06/03 09:28:24 UTC
[PR] [fix](chore) should not ignore returned Status [doris]
jacktengg opened a new pull request, #35806:
URL: https://github.com/apache/doris/pull/35806
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2145508567
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2510323385
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #35806:
URL: https://github.com/apache/doris/pull/35806#discussion_r1624665176
##########
be/src/exec/olap_common.h:
##########
@@ -963,7 +966,7 @@ bool ColumnValueRange<primitive_type>::is_in_range(const CppType& value) {
}
template <PrimitiveType primitive_type>
-void ColumnValueRange<primitive_type>::intersection(ColumnValueRange<primitive_type>& range) {
+Status ColumnValueRange<primitive_type>::intersection(ColumnValueRange<primitive_type>& range) {
Review Comment:
warning: function 'intersection' has cognitive complexity of 56 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status ColumnValueRange<primitive_type>::intersection(ColumnValueRange<primitive_type>& range) {
^
```
<details>
<summary>Additional context</summary>
**be/src/exec/olap_common.h:970:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (_column_type != range._column_type) {
^
```
**be/src/exec/olap_common.h:975:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_empty_value_range() || range.is_empty_value_range()) {
^
```
**be/src/exec/olap_common.h:975:** +1
```cpp
if (is_empty_value_range() || range.is_empty_value_range()) {
^
```
**be/src/exec/olap_common.h:981:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_fixed_value_range() || range.is_fixed_value_range() || range.is_match_value_range()) {
^
```
**be/src/exec/olap_common.h:981:** +1
```cpp
if (is_fixed_value_range() || range.is_fixed_value_range() || range.is_match_value_range()) {
^
```
**be/src/exec/olap_common.h:982:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (is_fixed_value_range() && range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:982:** +1
```cpp
if (is_fixed_value_range() && range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:986:** +1, nesting level increased to 2
```cpp
} else if (is_fixed_value_range() && !range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:986:** +1
```cpp
} else if (is_fixed_value_range() && !range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:989:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (iter != _fixed_values.end()) {
^
```
**be/src/exec/olap_common.h:990:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (range.is_in_range(*iter)) {
^
```
**be/src/exec/olap_common.h:995:** +1, nesting level increased to 2
```cpp
} else if (!is_fixed_value_range() && range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:995:** +1
```cpp
} else if (!is_fixed_value_range() && range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:997:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (iter != range._fixed_values.end()) {
^
```
**be/src/exec/olap_common.h:998:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (this->is_in_range(*iter)) {
^
```
**be/src/exec/olap_common.h:1005:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!result_values.empty()) {
^
```
**be/src/exec/olap_common.h:1010:** +1, nesting level increased to 2
```cpp
} else if (range.is_match_value_range()) {
^
```
**be/src/exec/olap_common.h:1011:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
for (auto& value : range._match_values) {
^
```
**be/src/exec/olap_common.h:1014:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/exec/olap_common.h:1017:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/exec/olap_common.h:1018:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (contain_null() && range.contain_null()) {
^
```
**be/src/exec/olap_common.h:1018:** +1
```cpp
if (contain_null() && range.contain_null()) {
^
```
**be/src/exec/olap_common.h:1020:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (!is_whole_value_range() || !range.is_whole_value_range()) {
^
```
**be/src/exec/olap_common.h:1020:** +1
```cpp
if (!is_whole_value_range() || !range.is_whole_value_range()) {
^
```
**be/src/exec/olap_common.h:1023:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/exec/olap_common.h:1024:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(add_range(range._high_op, range._high_value));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/olap_common.h:1024:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(add_range(range._high_op, range._high_value));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/olap_common.h:1025:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(add_range(range._low_op, range._low_value));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/olap_common.h:1025:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(add_range(range._low_op, range._low_value));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
##########
be/src/pipeline/exec/exchange_sink_operator.cpp:
##########
@@ -333,11 +333,11 @@ Status ExchangeSinkOperatorX::open(RuntimeState* state) {
}
template <typename ChannelPtrType>
-void ExchangeSinkOperatorX::_handle_eof_channel(RuntimeState* state, ChannelPtrType channel,
- Status st) {
+Status ExchangeSinkOperatorX::_handle_eof_channel(RuntimeState* state, ChannelPtrType channel,
+ Status st) {
channel->set_receiver_eof(st);
// Chanel will not send RPC to the downstream when eof, so close chanel by OK status.
- static_cast<void>(channel->close(state, Status::OK()));
+ return channel->close(state, Status::OK());
}
Status ExchangeSinkOperatorX::sink(RuntimeState* state, vectorized::Block* block, bool eos) {
Review Comment:
warning: function 'sink' has cognitive complexity of 289 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status ExchangeSinkOperatorX::sink(RuntimeState* state, vectorized::Block* block, bool eos) {
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/exchange_sink_operator.cpp:355:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (all_receiver_eof) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:359:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (_part_type == TPartitionType::UNPARTITIONED || local_state.channels.size() == 1) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:363:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (local_state.only_local_exchange) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:364:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (!block->empty()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:373:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:378:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(local_state._serializer.next_serialized_block(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:378:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._serializer.next_serialized_block(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:381:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (serialized) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:383:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (!cur_block.empty()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:384:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:384:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:387:** +1, nesting level increased to 4
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:411:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::RANDOM) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:415:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!current_channel->is_receiver_eof()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:417:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (current_channel->is_local()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:400:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:401:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
if (status.is<ErrorCode::END_OF_FILE>()) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +1, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:403:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
} else { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:420:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:422:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:422:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:400:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:401:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
if (status.is<ErrorCode::END_OF_FILE>()) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +1, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:403:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
} else { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:432:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::HASH_PARTITIONED ||
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:437:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:437:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:440:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (_part_type == TPartitionType::HASH_PARTITIONED) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:441:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(channel_add_rows(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:441:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(channel_add_rows(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:444:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:445:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(channel_add_rows(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:445:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(channel_add_rows(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:449:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::TABLET_SINK_SHUFFLE_PARTITIONED) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:451:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(local_state._send_new_partition_batch());
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:451:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(local_state._send_new_partition_batch());
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:458:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (input_rows > 0) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:463:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(local_state._row_distribution.generate_rows_distribution(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:463:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._row_distribution.generate_rows_distribution(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:469:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
for (int idx = 0; idx < row_ids.size(); ++idx) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:477:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (eos) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:479:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(local_state._send_new_partition_batch());
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:479:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._send_new_partition_batch());
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:481:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(channel_add_rows_with_idx(state, local_state.channels, num_channels,
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:481:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(channel_add_rows_with_idx(state, local_state.channels, num_channels,
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:483:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::TABLE_SINK_HASH_PARTITIONED) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:486:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:486:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:491:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(channel_add_rows_with_idx(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:491:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(channel_add_rows_with_idx(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:494:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::TABLE_SINK_RANDOM_PARTITIONED) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:499:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!current_channel->is_receiver_eof()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:501:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (current_channel->is_local()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:400:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:401:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
if (status.is<ErrorCode::END_OF_FILE>()) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +1, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:403:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
} else { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:504:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:506:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:506:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:400:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:401:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
if (status.is<ErrorCode::END_OF_FILE>()) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +1, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:403:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
} else { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:516:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (_writer_count < local_state.channels.size()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:517:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (_data_processed >=
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:524:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:531:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (eos) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:533:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
for (int i = 0; i < local_state.channels.size(); ++i) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:535:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (!st.ok() && final_st.ok()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:535:** +1
```cpp
if (!st.ok() && final_st.ok()) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2144722526
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2144721868
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2144832554
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on code in PR #35806:
URL: https://github.com/apache/doris/pull/35806#discussion_r1625486454
##########
be/src/pipeline/exec/set_sink_operator.cpp:
##########
@@ -88,21 +88,20 @@ Status SetSinkOperatorX<is_intersect>::_process_build_block(
vectorized::ColumnRawPtrs raw_ptrs(_child_exprs.size());
RETURN_IF_ERROR(_extract_build_column(local_state, block, raw_ptrs, rows));
- std::visit(
+ return std::visit(
[&](auto&& arg) {
using HashTableCtxType = std::decay_t<decltype(arg)>;
if constexpr (!std::is_same_v<HashTableCtxType, std::monostate>) {
vectorized::HashTableBuild<HashTableCtxType, is_intersect>
hash_table_build_process(&local_state, rows, raw_ptrs, state);
- static_cast<void>(hash_table_build_process(arg, local_state._arena));
+ return hash_table_build_process(arg, local_state._arena);
} else {
LOG(FATAL) << "FATAL: uninited hash table";
__builtin_unreachable();
+ return Status::InternalError("FATAL: uninited hash table");
Review Comment:
Why return after unreachable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #35806: [fix](chore) should not ignore returned Status
URL: https://github.com/apache/doris/pull/35806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on code in PR #35806:
URL: https://github.com/apache/doris/pull/35806#discussion_r1625487560
##########
be/src/pipeline/exec/set_sink_operator.cpp:
##########
@@ -88,21 +88,20 @@ Status SetSinkOperatorX<is_intersect>::_process_build_block(
vectorized::ColumnRawPtrs raw_ptrs(_child_exprs.size());
RETURN_IF_ERROR(_extract_build_column(local_state, block, raw_ptrs, rows));
- std::visit(
+ return std::visit(
[&](auto&& arg) {
using HashTableCtxType = std::decay_t<decltype(arg)>;
if constexpr (!std::is_same_v<HashTableCtxType, std::monostate>) {
vectorized::HashTableBuild<HashTableCtxType, is_intersect>
hash_table_build_process(&local_state, rows, raw_ptrs, state);
- static_cast<void>(hash_table_build_process(arg, local_state._arena));
+ return hash_table_build_process(arg, local_state._arena);
} else {
LOG(FATAL) << "FATAL: uninited hash table";
__builtin_unreachable();
+ return Status::InternalError("FATAL: uninited hash table");
Review Comment:
Compiler will complain if not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2144765014
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2144725447
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2144832479
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #35806:
URL: https://github.com/apache/doris/pull/35806#discussion_r1624125009
##########
be/src/pipeline/exec/exchange_sink_operator.cpp:
##########
@@ -333,11 +333,11 @@ Status ExchangeSinkOperatorX::open(RuntimeState* state) {
}
template <typename ChannelPtrType>
-void ExchangeSinkOperatorX::_handle_eof_channel(RuntimeState* state, ChannelPtrType channel,
- Status st) {
+Status ExchangeSinkOperatorX::_handle_eof_channel(RuntimeState* state, ChannelPtrType channel,
+ Status st) {
channel->set_receiver_eof(st);
// Chanel will not send RPC to the downstream when eof, so close chanel by OK status.
- static_cast<void>(channel->close(state, Status::OK()));
+ return channel->close(state, Status::OK());
}
Status ExchangeSinkOperatorX::sink(RuntimeState* state, vectorized::Block* block, bool eos) {
Review Comment:
warning: function 'sink' has cognitive complexity of 289 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status ExchangeSinkOperatorX::sink(RuntimeState* state, vectorized::Block* block, bool eos) {
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/exchange_sink_operator.cpp:355:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (all_receiver_eof) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:359:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (_part_type == TPartitionType::UNPARTITIONED || local_state.channels.size() == 1) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:363:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (local_state.only_local_exchange) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:364:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (!block->empty()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:373:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:378:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(local_state._serializer.next_serialized_block(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:378:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._serializer.next_serialized_block(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:381:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (serialized) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:383:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (!cur_block.empty()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:384:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:384:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:387:** +1, nesting level increased to 4
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:411:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::RANDOM) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:415:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!current_channel->is_receiver_eof()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:417:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (current_channel->is_local()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:400:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:401:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
if (status.is<ErrorCode::END_OF_FILE>()) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +1, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:403:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
} else { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:419:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:420:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:422:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:422:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:400:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:401:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
if (status.is<ErrorCode::END_OF_FILE>()) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +1, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:403:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
} else { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:426:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:432:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::HASH_PARTITIONED ||
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:437:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:437:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:440:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (_part_type == TPartitionType::HASH_PARTITIONED) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:441:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(channel_add_rows(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:441:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(channel_add_rows(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:444:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:445:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(channel_add_rows(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:445:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(channel_add_rows(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:449:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::TABLET_SINK_SHUFFLE_PARTITIONED) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:451:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(local_state._send_new_partition_batch());
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:451:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(local_state._send_new_partition_batch());
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:458:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (input_rows > 0) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:463:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(local_state._row_distribution.generate_rows_distribution(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:463:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._row_distribution.generate_rows_distribution(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:469:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
for (int idx = 0; idx < row_ids.size(); ++idx) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:477:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (eos) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:479:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(local_state._send_new_partition_batch());
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:479:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._send_new_partition_batch());
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:481:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(channel_add_rows_with_idx(state, local_state.channels, num_channels,
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:481:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(channel_add_rows_with_idx(state, local_state.channels, num_channels,
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:483:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::TABLE_SINK_HASH_PARTITIONED) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:486:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:486:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:491:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(channel_add_rows_with_idx(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:491:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(channel_add_rows_with_idx(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:494:** +1, nesting level increased to 1
```cpp
} else if (_part_type == TPartitionType::TABLE_SINK_RANDOM_PARTITIONED) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:499:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!current_channel->is_receiver_eof()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:501:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (current_channel->is_local()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:400:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:401:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
if (status.is<ErrorCode::END_OF_FILE>()) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +1, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:403:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
} else { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:503:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:504:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:506:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:506:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(local_state._serializer.serialize_block(
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:400:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:401:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
if (status.is<ErrorCode::END_OF_FILE>()) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:402:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(_handle_eof_channel(state, channel, status)); \
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +1, nesting level increased to 5
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:403:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
} else { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +6, including nesting penalty of 5, nesting level increased to 6
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:510:** +7, including nesting penalty of 6, nesting level increased to 7
```cpp
HANDLE_CHANNEL_STATUS(state, current_channel, status);
^
```
**be/src/vec/sink/vdata_stream_sender.h:404:** expanded from macro 'HANDLE_CHANNEL_STATUS'
```cpp
RETURN_IF_ERROR(status); \
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:516:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (_writer_count < local_state.channels.size()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:517:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (_data_processed >=
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:524:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:531:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (eos) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:533:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
for (int i = 0; i < local_state.channels.size(); ++i) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:535:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (!st.ok() && final_st.ok()) {
^
```
**be/src/pipeline/exec/exchange_sink_operator.cpp:535:** +1
```cpp
if (!st.ok() && final_st.ok()) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2145622390
TeamCity be ut coverage result:
Function Coverage: 36.24% (9240/25495)
Line Coverage: 27.57% (75858/275118)
Region Coverage: 26.82% (39299/146552)
Branch Coverage: 23.55% (19907/84528)
Coverage Report: http://coverage.selectdb-in.cc/coverage/83ce4da1464e2e7aae44fff0bb3342e721abd81b_83ce4da1464e2e7aae44fff0bb3342e721abd81b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #35806:
URL: https://github.com/apache/doris/pull/35806#discussion_r1624160632
##########
be/src/vec/functions/url/functions_url.h:
##########
@@ -73,8 +73,8 @@ using Pos = const char*;
*/
template <typename Extractor>
struct ExtractSubstringImpl {
- static void vector(const ColumnString::Chars& data, const ColumnString::Offsets& offsets,
Review Comment:
why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #35806:
URL: https://github.com/apache/doris/pull/35806#discussion_r1624124326
##########
be/src/exec/olap_common.h:
##########
@@ -962,7 +965,7 @@ bool ColumnValueRange<primitive_type>::is_in_range(const CppType& value) {
}
template <PrimitiveType primitive_type>
-void ColumnValueRange<primitive_type>::intersection(ColumnValueRange<primitive_type>& range) {
+Status ColumnValueRange<primitive_type>::intersection(ColumnValueRange<primitive_type>& range) {
Review Comment:
warning: function 'intersection' has cognitive complexity of 56 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status ColumnValueRange<primitive_type>::intersection(ColumnValueRange<primitive_type>& range) {
^
```
<details>
<summary>Additional context</summary>
**be/src/exec/olap_common.h:969:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (_column_type != range._column_type) {
^
```
**be/src/exec/olap_common.h:974:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_empty_value_range() || range.is_empty_value_range()) {
^
```
**be/src/exec/olap_common.h:974:** +1
```cpp
if (is_empty_value_range() || range.is_empty_value_range()) {
^
```
**be/src/exec/olap_common.h:980:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_fixed_value_range() || range.is_fixed_value_range() || range.is_match_value_range()) {
^
```
**be/src/exec/olap_common.h:980:** +1
```cpp
if (is_fixed_value_range() || range.is_fixed_value_range() || range.is_match_value_range()) {
^
```
**be/src/exec/olap_common.h:981:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (is_fixed_value_range() && range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:981:** +1
```cpp
if (is_fixed_value_range() && range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:985:** +1, nesting level increased to 2
```cpp
} else if (is_fixed_value_range() && !range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:985:** +1
```cpp
} else if (is_fixed_value_range() && !range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:988:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (iter != _fixed_values.end()) {
^
```
**be/src/exec/olap_common.h:989:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (range.is_in_range(*iter)) {
^
```
**be/src/exec/olap_common.h:994:** +1, nesting level increased to 2
```cpp
} else if (!is_fixed_value_range() && range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:994:** +1
```cpp
} else if (!is_fixed_value_range() && range.is_fixed_value_range()) {
^
```
**be/src/exec/olap_common.h:996:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (iter != range._fixed_values.end()) {
^
```
**be/src/exec/olap_common.h:997:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (this->is_in_range(*iter)) {
^
```
**be/src/exec/olap_common.h:1004:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!result_values.empty()) {
^
```
**be/src/exec/olap_common.h:1009:** +1, nesting level increased to 2
```cpp
} else if (range.is_match_value_range()) {
^
```
**be/src/exec/olap_common.h:1010:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
for (auto& value : range._match_values) {
^
```
**be/src/exec/olap_common.h:1013:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/exec/olap_common.h:1016:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/exec/olap_common.h:1017:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (contain_null() && range.contain_null()) {
^
```
**be/src/exec/olap_common.h:1017:** +1
```cpp
if (contain_null() && range.contain_null()) {
^
```
**be/src/exec/olap_common.h:1019:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
if (!is_whole_value_range() || !range.is_whole_value_range()) {
^
```
**be/src/exec/olap_common.h:1019:** +1
```cpp
if (!is_whole_value_range() || !range.is_whole_value_range()) {
^
```
**be/src/exec/olap_common.h:1022:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/exec/olap_common.h:1023:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(add_range(range._high_op, range._high_value));
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/olap_common.h:1023:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(add_range(range._high_op, range._high_value));
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/exec/olap_common.h:1024:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(add_range(range._low_op, range._low_value));
^
```
**be/src/common/status.h:614:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/exec/olap_common.h:1024:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(add_range(range._low_op, range._low_value));
^
```
**be/src/common/status.h:616:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](chore) should not ignore returned Status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35806:
URL: https://github.com/apache/doris/pull/35806#issuecomment-2144858454
TeamCity be ut coverage result:
Function Coverage: 36.30% (9240/25455)
Line Coverage: 27.66% (75859/274299)
Region Coverage: 26.88% (39305/146238)
Branch Coverage: 23.60% (19912/84364)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9734ecb46fbde2a192839ba587c09ca0bbba3082_9734ecb46fbde2a192839ba587c09ca0bbba3082/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org