You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 12:56:23 UTC

[GitHub] [arrow-rs] tustvold commented on issue #1531: Epic: enhance the `substring` kernel

tustvold commented on issue #1531:
URL: https://github.com/apache/arrow-rs/issues/1531#issuecomment-1098017580

   Coming at the problem from a Rust perspective, as opposed to potentially a query engine perspective, I personally would expect it to behave similarly to the standard library. That is:
   
   * [Bytes by default](https://doc.rust-lang.org/std/primitive.str.html#method.get), with validation that it isn't [splitting a codepoint](https://doc.rust-lang.org/std/primitive.str.html#method.is_char_boundary)
   * [Unsafe unchecked bytes APIs](https://doc.rust-lang.org/std/primitive.str.html#method.get_unchecked)
   * [Separate APIs](https://doc.rust-lang.org/std/primitive.str.html#method.chars) for operating on chars.
   
   That being said I don't really understand the use-cases of `substring` within a query engine context, i.e. if there is some SQL primitive it maps onto or something, and so if there is some standard practice here...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org