You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/06 07:39:27 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #1662: Remove parquet dictionary converters (#1661)

tustvold opened a new pull request, #1662:
URL: https://github.com/apache/arrow-rs/pull/1662

   # Which issue does this PR close?
   
   Part of #1161 
   
   Following #1180 these are no longer used
   
   # Rationale for this change
    
   Code cleanup
   
   # What changes are included in this PR?
   
   Removes some orphaned code
   
   # Are there any user-facing changes?
   
   No, the converter module is marked experimental
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb merged pull request #1662: Remove parquet dictionary converters (#1661)

Posted by GitBox <gi...@apache.org>.
alamb merged PR #1662:
URL: https://github.com/apache/arrow-rs/pull/1662


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on pull request #1662: Remove parquet dictionary converters (#1661)

Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #1662:
URL: https://github.com/apache/arrow-rs/pull/1662#issuecomment-1119939464

   No, this module is marked experimental so should be fine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on pull request #1662: Remove parquet dictionary converters (#1661)

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1662:
URL: https://github.com/apache/arrow-rs/pull/1662#issuecomment-1119917411

   @tustvold  can you confirm that this is (technically) an API change (as in it would be possible for someone to have code that relied on the `pub` struct that this removed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org