You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/11/04 19:39:38 UTC
Review Request 39947: Refactored mock allocator into a separate
header file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39947/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-3827
https://issues.apache.org/jira/browse/MESOS-3827
Repository: mesos
Description
-------
Refactored mock allocator into a separate header file.
Diffs
-----
src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
src/tests/allocator.hpp PRE-CREATION
src/tests/hierarchical_allocator_tests.cpp 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16
src/tests/master_allocator_tests.cpp 1fe3757f224281c312008e9010a95559cfff3dcf
src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
src/tests/reservation_endpoints_tests.cpp f5f9c4834779a3a84d12d9be77e674e2d6088b5d
src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
src/tests/resource_offers_tests.cpp af40a072bf5221cda42147e6f2c09d020a7f63f2
src/tests/slave_recovery_tests.cpp a50960c156da6adcab869a65ab9286adda188d2c
Diff: https://reviews.apache.org/r/39947/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 39947: Refactored mock allocator into a separate
header file.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39947/#review105202
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39946, 39947]
All tests passed.
- Mesos ReviewBot
On Nov. 5, 2015, 12:56 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39947/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 12:56 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3827
> https://issues.apache.org/jira/browse/MESOS-3827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored mock allocator into a separate header file.
>
>
> Diffs
> -----
>
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/allocator.hpp PRE-CREATION
> src/tests/hierarchical_allocator_tests.cpp 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16
> src/tests/master_allocator_tests.cpp 1fe3757f224281c312008e9010a95559cfff3dcf
> src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
> src/tests/reservation_endpoints_tests.cpp f5f9c4834779a3a84d12d9be77e674e2d6088b5d
> src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
> src/tests/resource_offers_tests.cpp af40a072bf5221cda42147e6f2c09d020a7f63f2
> src/tests/slave_recovery_tests.cpp a50960c156da6adcab869a65ab9286adda188d2c
>
> Diff: https://reviews.apache.org/r/39947/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39947: Refactored mock allocator into a separate
header file.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39947/#review105211
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十一月 5, 2015, 12:56 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39947/
> -----------------------------------------------------------
>
> (Updated 十一月 5, 2015, 12:56 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3827
> https://issues.apache.org/jira/browse/MESOS-3827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored mock allocator into a separate header file.
>
>
> Diffs
> -----
>
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/allocator.hpp PRE-CREATION
> src/tests/hierarchical_allocator_tests.cpp 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16
> src/tests/master_allocator_tests.cpp 1fe3757f224281c312008e9010a95559cfff3dcf
> src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
> src/tests/reservation_endpoints_tests.cpp f5f9c4834779a3a84d12d9be77e674e2d6088b5d
> src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
> src/tests/resource_offers_tests.cpp af40a072bf5221cda42147e6f2c09d020a7f63f2
> src/tests/slave_recovery_tests.cpp a50960c156da6adcab869a65ab9286adda188d2c
>
> Diff: https://reviews.apache.org/r/39947/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39947: Refactored mock allocator into a separate
header file.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39947/#review105670
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Nov. 5, 2015, 12:56 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39947/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 12:56 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3827
> https://issues.apache.org/jira/browse/MESOS-3827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored mock allocator into a separate header file.
>
>
> Diffs
> -----
>
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/allocator.hpp PRE-CREATION
> src/tests/hierarchical_allocator_tests.cpp 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16
> src/tests/master_allocator_tests.cpp 1fe3757f224281c312008e9010a95559cfff3dcf
> src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
> src/tests/reservation_endpoints_tests.cpp f5f9c4834779a3a84d12d9be77e674e2d6088b5d
> src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
> src/tests/resource_offers_tests.cpp af40a072bf5221cda42147e6f2c09d020a7f63f2
> src/tests/slave_recovery_tests.cpp a50960c156da6adcab869a65ab9286adda188d2c
>
> Diff: https://reviews.apache.org/r/39947/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39947: Refactored mock allocator into a separate
header file.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39947/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 12:56 a.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Rebase.
Bugs: MESOS-3827
https://issues.apache.org/jira/browse/MESOS-3827
Repository: mesos
Description
-------
Refactored mock allocator into a separate header file.
Diffs (updated)
-----
src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
src/tests/allocator.hpp PRE-CREATION
src/tests/hierarchical_allocator_tests.cpp 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16
src/tests/master_allocator_tests.cpp 1fe3757f224281c312008e9010a95559cfff3dcf
src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
src/tests/reservation_endpoints_tests.cpp f5f9c4834779a3a84d12d9be77e674e2d6088b5d
src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
src/tests/resource_offers_tests.cpp af40a072bf5221cda42147e6f2c09d020a7f63f2
src/tests/slave_recovery_tests.cpp a50960c156da6adcab869a65ab9286adda188d2c
Diff: https://reviews.apache.org/r/39947/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 39947: Refactored mock allocator into a separate
header file.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39947/#review105177
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39946, 39947]
All tests passed.
- Mesos ReviewBot
On Nov. 4, 2015, 6:39 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39947/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 6:39 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3827
> https://issues.apache.org/jira/browse/MESOS-3827
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored mock allocator into a separate header file.
>
>
> Diffs
> -----
>
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/allocator.hpp PRE-CREATION
> src/tests/hierarchical_allocator_tests.cpp 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16
> src/tests/master_allocator_tests.cpp 1fe3757f224281c312008e9010a95559cfff3dcf
> src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217
> src/tests/reservation_endpoints_tests.cpp f5f9c4834779a3a84d12d9be77e674e2d6088b5d
> src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e
> src/tests/resource_offers_tests.cpp af40a072bf5221cda42147e6f2c09d020a7f63f2
> src/tests/slave_recovery_tests.cpp a50960c156da6adcab869a65ab9286adda188d2c
>
> Diff: https://reviews.apache.org/r/39947/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>