You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2008/08/25 16:46:57 UTC
[RFC] Deprecate svn_opt_args_to_target_array2() in 1.5.x?
svn_opt_args_to_target_array2() was replaced by svn_opt_args_to_target_array3()
which is also available in 1.5.x.
svn_opt_args_to_target_array2() mistakenly wasn't marked with
the '@deprecated' tag.
I would like to add the '@deprecated' tag for svn_opt_args_to_target_array2().
Should I use:
@deprecated Provided for backward compatibility with the 1.4 API.
... or ...
@deprecated Provided for backward compatibility with the 1.5 API.
?
Personally I would prefer the first one and I also think that this change
should be backported to the 1.5.x branch.
Would anybody like to oppose to this?
--
Arfrever Frehtes Taifersar Arahesis
Re: [RFC] Deprecate svn_opt_args_to_target_array2() in 1.5.x?
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Arfrever Frehtes Taifersar Arahesis wrote:
> svn_opt_args_to_target_array2() was replaced by svn_opt_args_to_target_array3()
> which is also available in 1.5.x.
>
> svn_opt_args_to_target_array2() mistakenly wasn't marked with
> the '@deprecated' tag.
>
> I would like to add the '@deprecated' tag for svn_opt_args_to_target_array2().
> Should I use:
> @deprecated Provided for backward compatibility with the 1.4 API.
> ... or ...
> @deprecated Provided for backward compatibility with the 1.5 API.
> ?
>
> Personally I would prefer the first one and I also think that this change
> should be backported to the 1.5.x branch.
> Would anybody like to oppose to this?
If a symbol was in introduced in 1.x, previous versions of the symbol are
provided for compat with the 1.(x-1) API. If it isn't documented as such,
that's a doc bug.
-Hyrum
Re: [RFC] Deprecate svn_opt_args_to_target_array2() in 1.5.x?
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-08-25 21:40:12 Daniel Shahaf napisał(a):
> Arfrever Frehtes Taifersar Arahesis wrote on Mon, 25 Aug 2008 at 21:32 +0200:
> > 2008-08-25 20:50:41 Daniel Shahaf napisał(a):
> > > Arfrever Frehtes Taifersar Arahesis wrote on Mon, 25 Aug 2008 at 18:46 +0200:
> > > > svn_opt_args_to_target_array2() was replaced by svn_opt_args_to_target_array3()
> > > > which is also available in 1.5.x.
> > > >
> > > > svn_opt_args_to_target_array2() mistakenly wasn't marked with
> > > > the '@deprecated' tag.
> > > >
> > > > I would like to add the '@deprecated' tag for svn_opt_args_to_target_array2().
> > > > Should I use:
> > > > @deprecated Provided for backward compatibility with the 1.4 API.
> > > > ... or ...
> > > > @deprecated Provided for backward compatibility with the 1.5 API.
> > >
> > > +1 to the latter, its docstring in 1.5.x already says that it's an old
> > > version of _array3().
> >
> > Did you mean 'the former'?
> > (svn_opt_args_to_target_array2() is de facto provided for backward
> > compatibility with the 1.4 API.)
> >
>
> * @since New in 1.5.
> */
> svn_error_t *
> svn_opt_args_to_target_array3(apr_array_header_t **targets_p,
>
> Yes, sorry.
Fixed in r32708 + r32709.
--
Arfrever Frehtes Taifersar Arahesis
Re: [RFC] Deprecate svn_opt_args_to_target_array2() in 1.5.x?
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Arfrever Frehtes Taifersar Arahesis wrote on Mon, 25 Aug 2008 at 21:32 +0200:
> 2008-08-25 20:50:41 Daniel Shahaf napisał(a):
> > Arfrever Frehtes Taifersar Arahesis wrote on Mon, 25 Aug 2008 at 18:46 +0200:
> > > svn_opt_args_to_target_array2() was replaced by svn_opt_args_to_target_array3()
> > > which is also available in 1.5.x.
> > >
> > > svn_opt_args_to_target_array2() mistakenly wasn't marked with
> > > the '@deprecated' tag.
> > >
> > > I would like to add the '@deprecated' tag for svn_opt_args_to_target_array2().
> > > Should I use:
> > > @deprecated Provided for backward compatibility with the 1.4 API.
> > > ... or ...
> > > @deprecated Provided for backward compatibility with the 1.5 API.
> >
> > +1 to the latter, its docstring in 1.5.x already says that it's an old
> > version of _array3().
>
> Did you mean 'the former'?
> (svn_opt_args_to_target_array2() is de facto provided for backward
> compatibility with the 1.4 API.)
>
* @since New in 1.5.
*/
svn_error_t *
svn_opt_args_to_target_array3(apr_array_header_t **targets_p,
Yes, sorry.
Daniel
Re: [RFC] Deprecate svn_opt_args_to_target_array2() in 1.5.x?
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-08-25 20:50:41 Daniel Shahaf napisał(a):
> Arfrever Frehtes Taifersar Arahesis wrote on Mon, 25 Aug 2008 at 18:46 +0200:
> > svn_opt_args_to_target_array2() was replaced by svn_opt_args_to_target_array3()
> > which is also available in 1.5.x.
> >
> > svn_opt_args_to_target_array2() mistakenly wasn't marked with
> > the '@deprecated' tag.
> >
> > I would like to add the '@deprecated' tag for svn_opt_args_to_target_array2().
> > Should I use:
> > @deprecated Provided for backward compatibility with the 1.4 API.
> > ... or ...
> > @deprecated Provided for backward compatibility with the 1.5 API.
>
> +1 to the latter, its docstring in 1.5.x already says that it's an old
> version of _array3().
Did you mean 'the former'?
(svn_opt_args_to_target_array2() is de facto provided for backward
compatibility with the 1.4 API.)
--
Arfrever Frehtes Taifersar Arahesis
Re: [RFC] Deprecate svn_opt_args_to_target_array2() in 1.5.x?
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Arfrever Frehtes Taifersar Arahesis wrote on Mon, 25 Aug 2008 at 18:46 +0200:
> svn_opt_args_to_target_array2() was replaced by svn_opt_args_to_target_array3()
> which is also available in 1.5.x.
>
> svn_opt_args_to_target_array2() mistakenly wasn't marked with
> the '@deprecated' tag.
>
> I would like to add the '@deprecated' tag for svn_opt_args_to_target_array2().
> Should I use:
> @deprecated Provided for backward compatibility with the 1.4 API.
> ... or ...
> @deprecated Provided for backward compatibility with the 1.5 API.
+1 to the latter, its docstring in 1.5.x already says that it's an old
version of _array3().
> ?
>
> Personally I would prefer the first one and I also think that this change
> should be backported to the 1.5.x branch.
> Would anybody like to oppose to this?
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org