You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lh0156 (via GitHub)" <gi...@apache.org> on 2026/08/03 04:24:04 UTC
[PR] KAFKA-20692: Add unit tests for ToolsUtils [kafka]
lh0156 opened a new pull request, #23057:
URL: https://github.com/apache/kafka/pull/23057
## Summary\n\nAdd focused unit coverage for all public methods in :\n\n* deterministic metric ordering and type-specific formatting\n* tabular output alignment\n* valid and invalid bootstrap server addresses\n* duplicate detection without repeated results\n* non-mutating set subtraction\n\nThe tests document the existing behavior without changing production code.\n\n## Tests\n\n* > Task :api-checker:gradle-plugins:pluginDescriptors UP-TO-DATE
> Task :api-checker:gradle-plugins:processResources UP-TO-DATE
> Task :api-checker:core:compileJava UP-TO-DATE
> Task :api-checker:core:processResources NO-SOURCE
> Task :api-checker:core:classes UP-TO-DATE
> Task :api-checker:core:jar UP-TO-DATE
> Task :api-checker:gradle-plugins:compileJava UP-TO-DATE
> Task :api-checker:gradle-plugins:classes UP-TO-DATE
> Task :api-checker:gradle-plugins:jar UP-TO-DATE
> Configure project :
Starting build with version 4.4.0-SNAPSHOT (commit id unknown) using Gradle 9.4.1, Java 25 and Scala 2.13.18
Build properties: ignoreFailures=false, maxParallelForks=8, maxScalacThreads=8, maxTestRetries=0
> Task :core:processResources NO-SOURCE
> Task :metadata:processResources UP-TO-DATE
> Task :coordinator-common:processResources NO-SOURCE
> Task :group-coordinator:processResources UP-TO-DATE
> Task :server:processResources NO-SOURCE
> Task :raft:processResources UP-TO-DATE
> Task :server-common:processResources NO-SOURCE
> Task :clients:processResources UP-TO-DATE
> Task :server-common:createVersionFile UP-TO-DATE
> Task :raft:createVersionFile UP-TO-DATE
> Task :group-coordinator:group-coordinator-api:processResources NO-SOURCE
> Task :server:createVersionFile UP-TO-DATE
> Task :clients:createVersionFile UP-TO-DATE
> Task :storage:storage-api:processResources NO-SOURCE
> Task :share-coordinator:processResources UP-TO-DATE
> Task :clients:processTestFixturesResources NO-SOURCE
> Task :storage:processResources UP-TO-DATE
> Task :group-coordinator:group-coordinator-api:createVersionFile UP-TO-DATE
> Task :tools:tools-api:processResources NO-SOURCE
> Task :transaction-coordinator:processResources UP-TO-DATE
> Task :storage:storage-api:createVersionFile UP-TO-DATE
> Task :server-common:processTestFixturesResources NO-SOURCE
> Task :server:processTestFixturesResources UP-TO-DATE
> Task :tools:processResources NO-SOURCE
> Task :storage:createVersionFile UP-TO-DATE
> Task :tools:tools-api:createVersionFile UP-TO-DATE
> Task :storage:processTestFixturesResources NO-SOURCE
> Task :streams:processResources UP-TO-DATE
> Task :connect:api:processResources UP-TO-DATE
> Task :tools:processTestResources UP-TO-DATE
> Task :connect:runtime:processResources UP-TO-DATE
> Task :connect:transforms:processResources UP-TO-DATE
> Task :connect:json:processResources UP-TO-DATE
> Task :streams:createStreamsVersionFile UP-TO-DATE
> Task :streams:processTestFixturesResources NO-SOURCE
> Task :test-common:test-common-internal-api:processResources NO-SOURCE
> Task :test-common:test-common-runtime:processResources UP-TO-DATE
> Task :generator:compileJava UP-TO-DATE
> Task :test-common:test-common-util:compileJava UP-TO-DATE
> Task :generator:processResources NO-SOURCE
> Task :generator:classes UP-TO-DATE
> Task :test-common:test-common-util:processResources UP-TO-DATE
> Task :test-common:test-common-util:classes UP-TO-DATE
> Task :connect:runtime:processTestFixturesResources UP-TO-DATE
> Task :generator:jar UP-TO-DATE
> Task :test-common:test-common-util:jar UP-TO-DATE
> Task :clients:processMessages UP-TO-DATE
> Task :storage:processMessages UP-TO-DATE
> Task :raft:processMessages UP-TO-DATE
> Task :metadata:processMessages UP-TO-DATE
> Task :share-coordinator:processMessages UP-TO-DATE
> Task :streams:processMessages UP-TO-DATE
> Task :transaction-coordinator:processMessages UP-TO-DATE
> Task :group-coordinator:processMessages UP-TO-DATE
> Task :clients:compileJava UP-TO-DATE
> Task :clients:classes UP-TO-DATE
> Task :tools:tools-api:compileJava UP-TO-DATE
> Task :connect:api:compileJava UP-TO-DATE
> Task :group-coordinator:group-coordinator-api:compileJava UP-TO-DATE
> Task :tools:tools-api:classes UP-TO-DATE
> Task :group-coordinator:group-coordinator-api:classes UP-TO-DATE
> Task :server-common:compileJava UP-TO-DATE
> Task :server-common:classes UP-TO-DATE
> Task :group-coordinator:group-coordinator-api:jar UP-TO-DATE
> Task :connect:transforms:compileJava UP-TO-DATE
> Task :connect:api:classes UP-TO-DATE
> Task :connect:transforms:classes UP-TO-DATE
> Task :tools:tools-api:jar UP-TO-DATE
> Task :server-common:jar UP-TO-DATE
> Task :test-common:test-common-internal-api:compileJava UP-TO-DATE
> Task :connect:json:compileJava UP-TO-DATE
> Task :storage:storage-api:compileJava UP-TO-DATE
> Task :test-common:test-common-internal-api:classes UP-TO-DATE
> Task :clients:shadowJar UP-TO-DATE
> Task :connect:json:classes UP-TO-DATE
> Task :clients:jar SKIPPED
> Task :storage:storage-api:classes UP-TO-DATE
> Task :connect:api:copyDependantLibs UP-TO-DATE
> Task :storage:storage-api:jar UP-TO-DATE
> Task :test-common:test-common-internal-api:jar UP-TO-DATE
> Task :connect:api:jar UP-TO-DATE
> Task :connect:transforms:copyDependantLibs UP-TO-DATE
> Task :connect:transforms:jar UP-TO-DATE
> Task :connect:json:copyDependantLibs UP-TO-DATE
> Task :connect:json:jar UP-TO-DATE
> Task :storage:compileJava UP-TO-DATE
> Task :clients:compileTestFixturesJava UP-TO-DATE
> Task :streams:compileJava UP-TO-DATE
> Task :storage:classes UP-TO-DATE
> Task :streams:classes UP-TO-DATE
> Task :clients:testFixturesClasses UP-TO-DATE
> Task :storage:jar UP-TO-DATE
> Task :clients:testFixturesJar UP-TO-DATE
> Task :streams:copyDependantLibs UP-TO-DATE
> Task :raft:compileJava UP-TO-DATE
> Task :raft:classes UP-TO-DATE
> Task :raft:jar UP-TO-DATE
> Task :streams:jar UP-TO-DATE
> Task :storage:compileTestFixturesJava UP-TO-DATE
> Task :storage:testFixturesClasses UP-TO-DATE
> Task :metadata:compileJava UP-TO-DATE
> Task :metadata:classes UP-TO-DATE
> Task :metadata:jar UP-TO-DATE
> Task :storage:testFixturesJar UP-TO-DATE
> Task :server-common:compileTestFixturesJava UP-TO-DATE
> Task :streams:compileTestFixturesJava UP-TO-DATE
> Task :server-common:testFixturesClasses UP-TO-DATE
> Task :streams:testFixturesClasses UP-TO-DATE
> Task :connect:runtime:compileJava UP-TO-DATE
> Task :server-common:testFixturesJar UP-TO-DATE
> Task :coordinator-common:compileJava UP-TO-DATE
> Task :connect:runtime:classes UP-TO-DATE
> Task :streams:testFixturesJar UP-TO-DATE
> Task :coordinator-common:classes UP-TO-DATE
> Task :share-coordinator:compileJava UP-TO-DATE
> Task :transaction-coordinator:compileJava UP-TO-DATE
> Task :share-coordinator:classes UP-TO-DATE
> Task :group-coordinator:compileJava UP-TO-DATE
> Task :coordinator-common:jar UP-TO-DATE
> Task :group-coordinator:classes UP-TO-DATE
> Task :share-coordinator:jar UP-TO-DATE
> Task :transaction-coordinator:classes UP-TO-DATE
> Task :group-coordinator:jar UP-TO-DATE
> Task :transaction-coordinator:jar UP-TO-DATE
> Task :connect:runtime:copyDependantLibs UP-TO-DATE
> Task :connect:runtime:jar UP-TO-DATE
> Task :server:compileJava UP-TO-DATE
> Task :server:classes UP-TO-DATE
> Task :core:compileJava NO-SOURCE
> Task :server:jar UP-TO-DATE
> Task :tools:compileJava UP-TO-DATE
> Task :tools:classes UP-TO-DATE
> Task :tools:checkstyleMain UP-TO-DATE
> Task :server:compileTestFixturesJava UP-TO-DATE
> Task :server:testFixturesClasses UP-TO-DATE
> Task :server:testFixturesJar UP-TO-DATE
> Task :core:compileScala UP-TO-DATE
> Task :core:classes UP-TO-DATE
> Task :core:copyDependantLibs UP-TO-DATE
> Task :test-common:test-common-runtime:compileJava UP-TO-DATE
> Task :test-common:test-common-runtime:classes UP-TO-DATE
> Task :core:jar UP-TO-DATE
> Task :connect:runtime:compileTestFixturesJava UP-TO-DATE
> Task :test-common:test-common-runtime:jar UP-TO-DATE
> Task :connect:runtime:testFixturesClasses UP-TO-DATE
> Task :connect:runtime:testFixturesJar UP-TO-DATE
> Task :tools:spotbugsMain UP-TO-DATE
> Task :tools:compileTestJava UP-TO-DATE
> Task :tools:testClasses UP-TO-DATE
> Task :tools:checkstyleTest UP-TO-DATE
> Task :tools:test
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldRejectInvalidBootstrapServer(String) > "shouldRejectInvalidBootstrapServer(String).hostPort=null" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldRejectInvalidBootstrapServer(String) > "shouldRejectInvalidBootstrapServer(String).hostPort=" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldRejectInvalidBootstrapServer(String) > "shouldRejectInvalidBootstrapServer(String).hostPort=localhost" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldRejectInvalidBootstrapServer(String) > "shouldRejectInvalidBootstrapServer(String).hostPort=localhost:not-a-port" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldRejectInvalidBootstrapServer(String) > "shouldRejectInvalidBootstrapServer(String).hostPort=localhost:9092,invalid" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldPrintMetricsInSortedOrderWithTypeSpecificFormatting() PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldAcceptValidBootstrapServer(String) > "shouldAcceptValidBootstrapServer(String).hostPort=localhost:9092" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldAcceptValidBootstrapServer(String) > "shouldAcceptValidBootstrapServer(String).hostPort=host1:9091,host2:9092" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldAcceptValidBootstrapServer(String) > "shouldAcceptValidBootstrapServer(String).hostPort=[::1]:9092" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldReturnEachDuplicateOnlyOnce() PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldNotPrintMetricsWhenMetricsAreNullOrEmpty(Map) > "shouldNotPrintMetricsWhenMetricsAreNullOrEmpty(Map).metrics=null" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldNotPrintMetricsWhenMetricsAreNullOrEmpty(Map) > "shouldNotPrintMetricsWhenMetricsAreNullOrEmpty(Map).metrics={}" PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldPrintTableWithAlignedColumns() PASSED
Gradle Test Run :tools:test > Gradle Test Executor 103 > ToolsUtilsTest > shouldReturnCopyWithoutSpecifiedElements() PASSED
> Task :tools:copyTestXml SKIPPED
[Incubating] Problems report is available at: file:///Users/developseop/Desktop/kafka-20692/build/reports/problems/problems-report.html
Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to https://docs.gradle.org/9.4.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
BUILD SUCCESSFUL in 2s
110 actionable tasks: 1 executed, 109 up-to-date
Consider enabling configuration cache to speed up this build: https://docs.gradle.org/9.4.1/userguide/configuration_cache_enabling.html\n* > Task :api-checker:gradle-plugins:pluginDescriptors UP-TO-DATE
> Task :api-checker:gradle-plugins:processResources UP-TO-DATE
> Task :api-checker:core:compileJava UP-TO-DATE
> Task :api-checker:core:processResources NO-SOURCE
> Task :api-checker:core:classes UP-TO-DATE
> Task :api-checker:core:jar UP-TO-DATE
> Task :api-checker:gradle-plugins:compileJava UP-TO-DATE
> Task :api-checker:gradle-plugins:classes UP-TO-DATE
> Task :api-checker:gradle-plugins:jar UP-TO-DATE
> Configure project :
Starting build with version 4.4.0-SNAPSHOT (commit id unknown) using Gradle 9.4.1, Java 25 and Scala 2.13.18
Build properties: ignoreFailures=false, maxParallelForks=8, maxScalacThreads=8, maxTestRetries=0
> Task :clients:processResources UP-TO-DATE
> Task :clients:createVersionFile UP-TO-DATE
> Task :test-common:test-common-util:compileJava UP-TO-DATE
> Task :generator:compileJava UP-TO-DATE
> Task :generator:processResources NO-SOURCE
> Task :generator:classes UP-TO-DATE
> Task :generator:jar UP-TO-DATE
> Task :transaction-coordinator:processMessages UP-TO-DATE
> Task :clients:processMessages UP-TO-DATE
> Task :streams:processMessages UP-TO-DATE
> Task :metadata:processMessages UP-TO-DATE
> Task :share-coordinator:processMessages UP-TO-DATE
> Task :storage:processMessages UP-TO-DATE
> Task :raft:processMessages UP-TO-DATE
> Task :group-coordinator:processMessages UP-TO-DATE
> Task :clients:compileJava UP-TO-DATE
> Task :group-coordinator:group-coordinator-api:compileJava UP-TO-DATE
> Task :tools:tools-api:compileJava UP-TO-DATE
> Task :server-common:compileJava UP-TO-DATE
> Task :connect:api:compileJava UP-TO-DATE
> Task :connect:transforms:compileJava UP-TO-DATE
> Task :storage:storage-api:compileJava UP-TO-DATE
> Task :connect:json:compileJava UP-TO-DATE
> Task :test-common:test-common-internal-api:compileJava UP-TO-DATE
> Task :clients:compileTestFixturesJava UP-TO-DATE
> Task :clients:classes UP-TO-DATE
> Task :storage:compileJava UP-TO-DATE
> Task :raft:compileJava UP-TO-DATE
> Task :storage:compileTestFixturesJava UP-TO-DATE
> Task :metadata:compileJava UP-TO-DATE
> Task :clients:shadowJar UP-TO-DATE
> Task :streams:compileJava UP-TO-DATE
> Task :coordinator-common:compileJava UP-TO-DATE
> Task :share-coordinator:compileJava UP-TO-DATE
> Task :group-coordinator:compileJava UP-TO-DATE
> Task :server-common:compileTestFixturesJava UP-TO-DATE
> Task :transaction-coordinator:compileJava UP-TO-DATE
> Task :connect:runtime:compileJava UP-TO-DATE
> Task :streams:compileTestFixturesJava UP-TO-DATE
> Task :server:compileJava UP-TO-DATE
> Task :core:compileJava NO-SOURCE
> Task :server:compileTestFixturesJava UP-TO-DATE
> Task :core:compileScala UP-TO-DATE
> Task :test-common:test-common-runtime:compileJava UP-TO-DATE
> Task :connect:runtime:compileTestFixturesJava UP-TO-DATE
> Task :tools:spotlessJava UP-TO-DATE
> Task :tools:spotlessJavaCheck UP-TO-DATE
> Task :tools:spotlessCheck UP-TO-DATE
> Task :tools:compileJava UP-TO-DATE
> Task :tools:processResources NO-SOURCE
> Task :tools:classes UP-TO-DATE
> Task :tools:checkstyleMain UP-TO-DATE
> Task :tools:compileTestJava UP-TO-DATE
> Task :tools:processTestResources UP-TO-DATE
> Task :tools:testClasses UP-TO-DATE
> Task :tools:checkstyleTest UP-TO-DATE
> Task :tools:spotbugsMain UP-TO-DATE
[Incubating] Problems report is available at: file:///Users/developseop/Desktop/kafka-20692/build/reports/problems/problems-report.html
Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to https://docs.gradle.org/9.4.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
BUILD SUCCESSFUL in 1s
55 actionable tasks: 55 up-to-date
Consider enabling configuration cache to speed up this build: https://docs.gradle.org/9.4.1/userguide/configuration_cache_enabling.html\n* \n\nThe full suite was also started. The new cases passed, while unrelated integration tests encountered environment/timing failures in SASL consumer-group discovery and Connect Raft server startup; the long-running suite was stopped after those failures were observed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20692: Add unit tests for ToolsUtils [kafka]
Posted by "lh0156 (via GitHub)" <gi...@apache.org>.
lh0156 commented on PR #23057:
URL: https://github.com/apache/kafka/pull/23057#issuecomment-5162285122
Closing this duplicate contribution. KAFKA-20692 is already addressed by the existing PR #22577.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20692: Add unit tests for ToolsUtils [kafka]
Posted by "lh0156 (via GitHub)" <gi...@apache.org>.
lh0156 closed pull request #23057: KAFKA-20692: Add unit tests for ToolsUtils
URL: https://github.com/apache/kafka/pull/23057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org