You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by ma...@apache.org on 2012/08/19 17:52:13 UTC

svn commit: r1374776 - in /ant/ivy/core/trunk: CHANGES.txt src/java/org/apache/ivy/core/module/id/ModuleId.java

Author: maartenc
Date: Sun Aug 19 15:52:13 2012
New Revision: 1374776

URL: http://svn.apache.org/viewvc?rev=1374776&view=rev
Log:
FIX: Memory leak and infinite loop in ModuleId.java (IVY-1362)

Modified:
    ant/ivy/core/trunk/CHANGES.txt
    ant/ivy/core/trunk/src/java/org/apache/ivy/core/module/id/ModuleId.java

Modified: ant/ivy/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/CHANGES.txt?rev=1374776&r1=1374775&r2=1374776&view=diff
==============================================================================
--- ant/ivy/core/trunk/CHANGES.txt (original)
+++ ant/ivy/core/trunk/CHANGES.txt Sun Aug 19 15:52:13 2012
@@ -130,6 +130,7 @@ for detailed view of each issue, please 
 	
    trunk
 =====================================
+- FIX: Memory leak and infinite loop in ModuleId.java (IVY-1362)
 - FIX: Unnecessary warning when parent ivy.xml is not found (IVY-1346)
 - FIX: StackOverflowError when using <extends> and ../ivy.xml is not the parent ivy.xml (IVY-1437)
 - FIX: NullPointerExeption in AbstractOSGiResolver (IVY-1343) (thanks to Thomas Kurpick)

Modified: ant/ivy/core/trunk/src/java/org/apache/ivy/core/module/id/ModuleId.java
URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/src/java/org/apache/ivy/core/module/id/ModuleId.java?rev=1374776&r1=1374775&r2=1374776&view=diff
==============================================================================
--- ant/ivy/core/trunk/src/java/org/apache/ivy/core/module/id/ModuleId.java (original)
+++ ant/ivy/core/trunk/src/java/org/apache/ivy/core/module/id/ModuleId.java Sun Aug 19 15:52:13 2012
@@ -59,7 +59,7 @@ public class ModuleId implements Compara
      *            the module id to return
      * @return a unit instance of the given module id.
      */
-    public static ModuleId intern(ModuleId moduleId) {
+    public static synchronized ModuleId intern(ModuleId moduleId) {
         ModuleId r = (ModuleId) CACHE.get(moduleId);
         if (r == null) {
             r = moduleId;