You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/01/27 00:31:11 UTC
Review Request 56005: Added a safety CHECK when accessing activeRoles
in the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56005/
-----------------------------------------------------------
Review request for mesos, Michael Park and Neil Conway.
Repository: mesos
Description
-------
Currently there is a use of the [] operator that is not preceded
by a CHECK that the key is contained in the map. This leads to a
hard to diagnose issue if there are bugs that violate this
assumption.
Diffs
-----
src/master/master.cpp 0f2c7cd32161576fad742ef350dff64874b80854
Diff: https://reviews.apache.org/r/56005/diff/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 56005: Added a safety CHECK when accessing
activeRoles in the master.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56005/#review163444
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Jan. 27, 2017, 12:31 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56005/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 12:31 a.m.)
>
>
> Review request for mesos, Michael Park and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently there is a use of the [] operator that is not preceded
> by a CHECK that the key is contained in the map. This leads to a
> hard to diagnose issue if there are bugs that violate this
> assumption.
>
>
> Diffs
> -----
>
> src/master/master.cpp 0f2c7cd32161576fad742ef350dff64874b80854
>
> Diff: https://reviews.apache.org/r/56005/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 56005: Added a safety CHECK when accessing
activeRoles in the master.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56005/#review163224
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On \u4e00\u6708 27, 2017, 12:31 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56005/
> -----------------------------------------------------------
>
> (Updated \u4e00\u6708 27, 2017, 12:31 a.m.)
>
>
> Review request for mesos, Michael Park and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently there is a use of the [] operator that is not preceded
> by a CHECK that the key is contained in the map. This leads to a
> hard to diagnose issue if there are bugs that violate this
> assumption.
>
>
> Diffs
> -----
>
> src/master/master.cpp 0f2c7cd32161576fad742ef350dff64874b80854
>
> Diff: https://reviews.apache.org/r/56005/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>