Spec clarification and bug 45451

[Mark Thomas <ma...@apache.org>]

All,

I received clarification from the EG today.

In summary, the question was which of the following is correct:
1: <test:echo text="${"hello world"}" />
2: <test:echo text="${\"hello world\"}" />

A strict reading of the EBNF grammar in the JSP spec suggested that 1 was
correct.

The TCK expected 2.

The EG have confirmed that the TCK is correct. I am still following up on
if I have mis-read the EBNF - always a possibility ;) - or if some form of
clarification is required.

To be clear, the intention of the spec is that attributes are always quoted
 as per JSP.1.6. Once the value has been 'de-quoted' it can be passed to
the EL engine for processing.

I will start work on getting the necessary changes implemented in trunk and
then propose patches for 6.0.x. Changes may also be required for 5.5.x

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Spec clarification and bug 45451

[Mark Thomas <ma...@apache.org>]

Remy Maucherat wrote:
> On Tue, 2008-10-07 at 16:51 +0100, Mark Thomas wrote:
>> I will start work on getting the necessary changes implemented in trunk and
>> then propose patches for 6.0.x. Changes may also be required for 5.5.x
> 
> Ok. The change to the Parser made it that EL was no longer unescaped. So
> if I understand correctly your strategy will be to update the EL parser
> so that it deals with the unescaping, right ?

That is certainly one possibility although not the only one. There were all
sorts of edge cases and I want to come up with the simplest solution that
fits all the edge cases. It is probably the case that some of my previous
changes will need to be reverted.

I have various meetings to go to this week but I hope to have something by
the end of the week.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Spec clarification and bug 45451

[Remy Maucherat <re...@apache.org>]

On Tue, 2008-10-07 at 16:51 +0100, Mark Thomas wrote:
> I will start work on getting the necessary changes implemented in trunk and
> then propose patches for 6.0.x. Changes may also be required for 5.5.x

Ok. The change to the Parser made it that EL was no longer unescaped. So
if I understand correctly your strategy will be to update the EL parser
so that it deals with the unescaping, right ?

Rémy



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org