You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2008/06/05 02:15:44 UTC
[jira] Created: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Name-node shutdown causes InterruptedException in ResolutionMonitor
-------------------------------------------------------------------
Key: HADOOP-3491
URL: https://issues.apache.org/jira/browse/HADOOP-3491
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Affects Versions: 0.16.0
Reporter: Konstantin Shvachko
Fix For: 0.18.0
ResolutionMonitor.run() catches a general Exception and logs them no matter what.
It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603201#action_12603201 ]
Lohit Vijayarenu commented on HADOOP-3491:
------------------------------------------
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch, HADOOP-3491-2.patch, HADOOP-3491-3.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lohit Vijayarenu updated HADOOP-3491:
-------------------------------------
Status: Patch Available (was: Open)
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch, HADOOP-3491-2.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lohit Vijayarenu updated HADOOP-3491:
-------------------------------------
Status: Open (was: Patch Available)
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lohit Vijayarenu updated HADOOP-3491:
-------------------------------------
Attachment: HADOOP-3491-3.patch
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch, HADOOP-3491-2.patch, HADOOP-3491-3.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603169#action_12603169 ]
Lohit Vijayarenu commented on HADOOP-3491:
------------------------------------------
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
No tests, I manually checked logs and dont see strack dump as earlier.
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603182#action_12603182 ]
Konstantin Shvachko commented on HADOOP-3491:
---------------------------------------------
I think InterruptedException should be caught inside the loop so that the ResolutionMonitor could check fsRunning and decide what to do based on its value.
And there should be no messages higher than debug level, imo.
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603247#action_12603247 ]
Hadoop QA commented on HADOOP-3491:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12383602/HADOOP-3491-3.patch
against trunk revision 664159.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2612/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2612/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2612/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2612/console
This message is automatically generated.
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Assignee: Lohit Vijayarenu
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch, HADOOP-3491-2.patch, HADOOP-3491-3.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lohit Vijayarenu updated HADOOP-3491:
-------------------------------------
Attachment: HADOOP-3491-2.patch
Thanks Konstantin, Second try with your comments.
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch, HADOOP-3491-2.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-3491:
----------------------------------------
Resolution: Fixed
Assignee: Lohit Vijayarenu
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thank you Lohit.
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Assignee: Lohit Vijayarenu
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch, HADOOP-3491-2.patch, HADOOP-3491-3.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603210#action_12603210 ]
Konstantin Shvachko commented on HADOOP-3491:
---------------------------------------------
+1
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch, HADOOP-3491-2.patch, HADOOP-3491-3.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lohit Vijayarenu updated HADOOP-3491:
-------------------------------------
Attachment: HADOOP-3491-1.patch
Attached patch, catches the exception and logs a one line warning instead of whole stack trace.
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3491) Name-node shutdown causes
InterruptedException in ResolutionMonitor
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lohit Vijayarenu updated HADOOP-3491:
-------------------------------------
Status: Patch Available (was: Open)
> Name-node shutdown causes InterruptedException in ResolutionMonitor
> -------------------------------------------------------------------
>
> Key: HADOOP-3491
> URL: https://issues.apache.org/jira/browse/HADOOP-3491
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.0
> Reporter: Konstantin Shvachko
> Fix For: 0.18.0
>
> Attachments: HADOOP-3491-1.patch
>
>
> ResolutionMonitor.run() catches a general Exception and logs them no matter what.
> It should explicitly catch the InterruptedException and exit gracefully.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.