You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/14 07:16:59 UTC

[GitHub] [flink] azagrebin commented on a change in pull request #12110: [FLINK-17652][config] Legacy JM heap options should fallback to new JVM_HEAP_MEMORY in standalone

azagrebin commented on a change in pull request #12110:
URL: https://github.com/apache/flink/pull/12110#discussion_r424919541



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/bash/BashJavaUtils.java
##########
@@ -78,7 +78,7 @@ private static Configuration getConfigurationForStandaloneTaskManagers(String[]
 	private static void getJmResourceParams(String[] args) throws Exception {
 		JobManagerProcessSpec jobManagerProcessSpec = JobManagerProcessUtils.processSpecFromConfigWithFallbackForLegacyHeap(

Review comment:
       alright, I added a hotfix renaming it to `processSpecFromConfigWithNewOptionToInterpretLegacyHeap(.., newOptionToInterpretLegacyHeap)`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org