You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/18 15:39:04 UTC

[GitHub] [spark] MaxGekk opened a new pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

MaxGekk opened a new pull request #32225:
URL: https://github.com/apache/spark/pull/32225


   ### What changes were proposed in this pull request?
   Add checks for `YearMonthIntervalType` and `DayTimeIntervalType` to `MutableProjectionSuite`.
   
   ### Why are the changes needed?
   To improve test coverage, and the same checks as for `CalendarIntervalType`.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   By running the modified test suite:
   ```
   $ build/sbt "test:testOnly *MutableProjectionSuite"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32225:
URL: https://github.com/apache/spark/pull/32225#issuecomment-822014060


   **[Test build #137534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137534/testReport)** for PR 32225 at commit [`38f92aa`](https://github.com/apache/spark/commit/38f92aac81be7b4a01fe9424bc1156804751e566).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32225:
URL: https://github.com/apache/spark/pull/32225#issuecomment-822059653


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137534/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32225:
URL: https://github.com/apache/spark/pull/32225#issuecomment-822088170


   Looks fine. Merged to master. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32225:
URL: https://github.com/apache/spark/pull/32225#issuecomment-822014060


   **[Test build #137534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137534/testReport)** for PR 32225 at commit [`38f92aa`](https://github.com/apache/spark/commit/38f92aac81be7b4a01fe9424bc1156804751e566).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32225:
URL: https://github.com/apache/spark/pull/32225#issuecomment-822022895


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42108/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32225:
URL: https://github.com/apache/spark/pull/32225#issuecomment-822053605


   **[Test build #137534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137534/testReport)** for PR 32225 at commit [`38f92aa`](https://github.com/apache/spark/commit/38f92aac81be7b4a01fe9424bc1156804751e566).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu closed pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
maropu closed pull request #32225:
URL: https://github.com/apache/spark/pull/32225


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32225:
URL: https://github.com/apache/spark/pull/32225#issuecomment-822059653


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137534/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32225:
URL: https://github.com/apache/spark/pull/32225#issuecomment-822020519






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32225: [SPARK-35115][SQL][TESTS] Check ANSI intervals in `MutableProjectionSuite`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32225:
URL: https://github.com/apache/spark/pull/32225#issuecomment-822022895


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42108/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org