[GitHub] [geode-native] moleske commented on a change in pull request #618: GEODE-8246: Enfore No Shadow as error

[GitBox <gi...@apache.org>]

moleske commented on a change in pull request #618:
URL: https://github.com/apache/geode-native/pull/618#discussion_r439531694



##########
File path: cppcache/src/ClientMetadataService.cpp
##########
@@ -765,18 +766,17 @@ void ClientMetadataService::markPrimaryBucketForTimeoutButLookSecondaryBucket(
                           serverLocation, version);
 
   std::shared_ptr<ClientMetadata> cptr = nullptr;
-  {
-    boost::shared_lock<decltype(m_regionMetadataLock)> lock(
-        m_regionMetadataLock);
 
-    const auto& cptrIter = m_regionMetaDataMap.find(region->getFullPath());
-    if (cptrIter != m_regionMetaDataMap.end()) {
-      cptr = cptrIter->second;
-    }
+  boost::shared_lock<decltype(m_regionMetadataLock)> boostRegionMetadataLock(

Review comment:
       I feel like a test should have failed cause of this change.  Will have to save looking for that test for another PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org