You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2022/06/03 13:41:08 UTC

[Impala-ASF-CR] IMPALA-11323: Don't evaluate constants-only inferred predicates

Hello Quanlong Huang, Aman Sinha, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18579

to look at the new patch set (#3).

Change subject: IMPALA-11323: Don't evaluate constants-only inferred predicates
......................................................................

IMPALA-11323: Don't evaluate constants-only inferred predicates

IMPALA-101822 fixed the problem of creating inferred predicates when
both sides of an equality predicate came from the same slot.

Inferred predicates also should not be created when both sides
of an equality predicate are constant values which do not have
scan slots.

Change-Id: If1cd4559dda406d2d38703ed594b70b41ed336fd
---
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/planner/PlanNode.java
M testdata/workloads/functional-query/queries/QueryTest/inline-view.test
3 files changed, 62 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/18579/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1cd4559dda406d2d38703ed594b70b41ed336fd
Gerrit-Change-Number: 18579
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>