[GitHub] [cordova-android] breautek commented on issue #792: Gradle upgrade from 4.10.3 to 5.x

[GitBox <gi...@apache.org>]

breautek commented on issue #792: Gradle upgrade from 4.10.3 to 5.x
URL: https://github.com/apache/cordova-android/pull/792#issuecomment-529259863
 
 
   @erisu FYI, I opted away from the `git clean` method as you suggested. I originally liked the idea and even used it my own personal project. However, I had a situation where I accidentally deleted untracked files that was intended to added to the repo because `git clean` was ran as a part of a script.
   
   Due to this danger I decided to replace it with a `gulpfile` implementation. I see that `gulp` is already used in the `cordova-docs` library, so I assume it wouldn't be a big deal adding a dev dependency here. The gulpfile contains a `clean` task to clean files that we need to specifically clean, which is currently `./test/gradlew` && `./test/gradlew.bat`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org