You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/12/07 18:52:50 UTC
Review Request: FLUME-1769.Replicating channel selector should support
optional channels
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Replicating channel selector should support optional channels
This addresses bug FLUME-1769.
https://issues.apache.org/jira/browse/FLUME-1769
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 866d9dc
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
Diff: https://reviews.apache.org/r/8413/diff/
Testing
-------
Added unit tests to handle this case
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On Dec. 7, 2012, 8:30 p.m., Brock Noland wrote:
> > flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java, line 73
> > <https://reviews.apache.org/r/8413/diff/5/?file=235844#file235844line73>
> >
> > The method that was deleted channels being null. That should be handled here as well, correct?
> >
> > I am seeing the following tests failures:
> >
> > Tests in error:
> > testNoDefault(org.apache.flume.channel.TestMultiplexingChannelSelector)
> > testOnlyOptional(org.apache.flume.channel.TestMultiplexingChannelSelector)
Ah sorry. Since the 2 patches affected the same code, looks like some code ended up missing.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/#review14181
-----------------------------------------------------------
On Dec. 7, 2012, 8:05 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8413/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2012, 8:05 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Replicating channel selector should support optional channels
>
>
> This addresses bug FLUME-1769.
> https://issues.apache.org/jira/browse/FLUME-1769
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
> flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 54e4b20
> flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
> flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
> flume-ng-doc/sphinx/FlumeUserGuide.rst 70cb285
>
> Diff: https://reviews.apache.org/r/8413/diff/
>
>
> Testing
> -------
>
> Added unit tests to handle this case
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/#review14181
-----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java
<https://reviews.apache.org/r/8413/#comment30288>
The method that was deleted channels being null. That should be handled here as well, correct?
I am seeing the following tests failures:
Tests in error:
testNoDefault(org.apache.flume.channel.TestMultiplexingChannelSelector)
testOnlyOptional(org.apache.flume.channel.TestMultiplexingChannelSelector)
- Brock Noland
On Dec. 7, 2012, 8:05 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8413/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2012, 8:05 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Replicating channel selector should support optional channels
>
>
> This addresses bug FLUME-1769.
> https://issues.apache.org/jira/browse/FLUME-1769
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
> flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 54e4b20
> flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
> flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
> flume-ng-doc/sphinx/FlumeUserGuide.rst 70cb285
>
> Diff: https://reviews.apache.org/r/8413/diff/
>
>
> Testing
> -------
>
> Added unit tests to handle this case
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/#review14190
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Dec. 7, 2012, 9:12 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8413/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2012, 9:12 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Replicating channel selector should support optional channels
>
>
> This addresses bug FLUME-1769.
> https://issues.apache.org/jira/browse/FLUME-1769
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
> flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 54e4b20
> flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
> flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
> flume-ng-doc/sphinx/FlumeUserGuide.rst 70cb285
>
> Diff: https://reviews.apache.org/r/8413/diff/
>
>
> Testing
> -------
>
> Added unit tests to handle this case
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/
-----------------------------------------------------------
(Updated Dec. 7, 2012, 9:12 p.m.)
Review request for Flume.
Changes
-------
Fixing an issue introduced by the rebase.
Description
-------
Replicating channel selector should support optional channels
This addresses bug FLUME-1769.
https://issues.apache.org/jira/browse/FLUME-1769
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 54e4b20
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
flume-ng-doc/sphinx/FlumeUserGuide.rst 70cb285
Diff: https://reviews.apache.org/r/8413/diff/
Testing
-------
Added unit tests to handle this case
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/
-----------------------------------------------------------
(Updated Dec. 7, 2012, 8:05 p.m.)
Review request for Flume.
Changes
-------
Rebased
Description
-------
Replicating channel selector should support optional channels
This addresses bug FLUME-1769.
https://issues.apache.org/jira/browse/FLUME-1769
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 54e4b20
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
flume-ng-doc/sphinx/FlumeUserGuide.rst 70cb285
Diff: https://reviews.apache.org/r/8413/diff/
Testing
-------
Added unit tests to handle this case
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Brock Noland <br...@cloudera.com>.
> On Dec. 7, 2012, 7:28 p.m., Brock Noland wrote:
> > Nice work Hari! I'll run the tests and commit if they pass!
Looks like it needs a small rebase.
+ patch -p1 --dry-run
patching file flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java
patching file flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java
Hunk #2 FAILED at 149.
1 out of 2 hunks FAILED -- saving rejects to file flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java.rej
patching file flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java
patching file flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java
patching file flume-ng-doc/sphinx/FlumeUserGuide.rst
Hunk #1 succeeded at 1806 (offset 1 line).
Hunk #2 succeeded at 1821 (offset 1 line).
$ git reset --hard HEAD
HEAD is now at 15af0ce FLUME-1768: Multiplexing channel selector should allow optional-only channels
$ git apply /data/patches/FLUME-1769-1.patch
error: patch failed: flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java:152
error: flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java: patch does not apply
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/#review14176
-----------------------------------------------------------
On Dec. 7, 2012, 7:12 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8413/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2012, 7:12 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Replicating channel selector should support optional channels
>
>
> This addresses bug FLUME-1769.
> https://issues.apache.org/jira/browse/FLUME-1769
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
> flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 866d9dc
> flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
> flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
> flume-ng-doc/sphinx/FlumeUserGuide.rst f8528bb
>
> Diff: https://reviews.apache.org/r/8413/diff/
>
>
> Testing
> -------
>
> Added unit tests to handle this case
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/#review14176
-----------------------------------------------------------
Nice work Hari! I'll run the tests and commit if they pass!
- Brock Noland
On Dec. 7, 2012, 7:12 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8413/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2012, 7:12 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Replicating channel selector should support optional channels
>
>
> This addresses bug FLUME-1769.
> https://issues.apache.org/jira/browse/FLUME-1769
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
> flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 866d9dc
> flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
> flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
> flume-ng-doc/sphinx/FlumeUserGuide.rst f8528bb
>
> Diff: https://reviews.apache.org/r/8413/diff/
>
>
> Testing
> -------
>
> Added unit tests to handle this case
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/
-----------------------------------------------------------
(Updated Dec. 7, 2012, 7:12 p.m.)
Review request for Flume.
Changes
-------
Removed some whitespace changes from the user guide.
Description
-------
Replicating channel selector should support optional channels
This addresses bug FLUME-1769.
https://issues.apache.org/jira/browse/FLUME-1769
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 866d9dc
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
flume-ng-doc/sphinx/FlumeUserGuide.rst f8528bb
Diff: https://reviews.apache.org/r/8413/diff/
Testing
-------
Added unit tests to handle this case
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/
-----------------------------------------------------------
(Updated Dec. 7, 2012, 7:09 p.m.)
Review request for Flume.
Description
-------
Replicating channel selector should support optional channels
This addresses bug FLUME-1769.
https://issues.apache.org/jira/browse/FLUME-1769
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 866d9dc
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
flume-ng-doc/sphinx/FlumeUserGuide.rst f8528bb
Diff: https://reviews.apache.org/r/8413/diff/
Testing
-------
Added unit tests to handle this case
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1769.Replicating channel selector should support
optional channels
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/
-----------------------------------------------------------
(Updated Dec. 7, 2012, 7:02 p.m.)
Review request for Flume.
Description
-------
Replicating channel selector should support optional channels
This addresses bug FLUME-1769.
https://issues.apache.org/jira/browse/FLUME-1769
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 866d9dc
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
flume-ng-doc/sphinx/FlumeUserGuide.rst f8528bb
Diff: https://reviews.apache.org/r/8413/diff/
Testing
-------
Added unit tests to handle this case
Thanks,
Hari Shreedharan