[jira] [Commented] (HIVE-9160) Suspicious comparing logic in LazyPrimitive

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251624#comment-14251624 ] 

Hive QA commented on HIVE-9160:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12687981/HIVE-9160.1.patch.txt

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 6714 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan
org.apache.hive.hcatalog.streaming.TestStreaming.testEndpointConnection
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2126/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2126/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2126/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12687981 - PreCommit-HIVE-TRUNK-Build

> Suspicious comparing logic in LazyPrimitive
> -------------------------------------------
>
>                 Key: HIVE-9160
>                 URL: https://issues.apache.org/jira/browse/HIVE-9160
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-9160.1.patch.txt
>
>
> {code}
>   @Override
>   public boolean equals(Object obj) {
>     if (!(obj instanceof LazyPrimitive<?, ?>)) {
>       return false;
>     }
>     if (data == obj) {
>       return true;
>     }
>     if (data == null || obj == null) {
>       return false;
>     }
>     return data.equals(((LazyPrimitive<?, ?>) obj).getWritableObject());
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)