You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/07 15:17:18 UTC
[GitHub] [incubator-tvm] leandron opened a new pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
leandron opened a new pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643
This change improves TEDD testing, so that is can run on `ci-cpu` Docker image. It currently fails if you try to run it on a `ci-cpu` image that has `graphviz` installed. The test currently shows as "passing" in CI, but checks are not actually done.
We still need to have a separate PR to install graphviz on `ci-cpu`, to make this test to actually do something. In this PR, we only will be able to obeserve that it doesn't break the current setup. Reported on #6642 (more context there).
cc @yongfeng-nv @tqchen for reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron edited a comment on pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron edited a comment on pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#issuecomment-705686283
Once this is merged, I'd consider it closes #6642.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on a change in pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#discussion_r501828116
##########
File path: tests/python/contrib/test_tedd.py
##########
@@ -14,9 +14,13 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-from tvm import te
-import numpy as np
import re
+
+import numpy as np
+
+import pytest
Review comment:
Good point. Numpy was there before and didn't notice it wasn't used. I tried using pytest.importorskip, but it didn't do the trick. in the end, that is a leftover. I'll fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron edited a comment on pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron edited a comment on pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#issuecomment-706214075
If possible, can we merge this? Just asking, so that I can fix my own CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#discussion_r501825001
##########
File path: tests/python/contrib/test_tedd.py
##########
@@ -14,9 +14,13 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-from tvm import te
-import numpy as np
import re
+
+import numpy as np
+
+import pytest
Review comment:
Is this needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on a change in pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#discussion_r501828116
##########
File path: tests/python/contrib/test_tedd.py
##########
@@ -14,9 +14,13 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-from tvm import te
-import numpy as np
import re
+
+import numpy as np
+
+import pytest
Review comment:
Good point. Numpy was there before and didn't notice it wasn't used. I tried using pytest.importorskip, but it didn't do the trick. in the end, that is a leftover. I'll fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#issuecomment-705443958
Also cc @zhiics @FrozenGene for reviews and merge if you are happy with this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#issuecomment-705686283
Once this is merged, I'd consider is closes #6642.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron edited a comment on pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron edited a comment on pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#issuecomment-705686283
Once this is merged, I'd consider it closes #6642.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#issuecomment-706214075
If this possible to merge this? Just asking, so that I can fix my own CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#issuecomment-705030432
Retriggering, due to some CI crash at build time, not related to this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#discussion_r501825001
##########
File path: tests/python/contrib/test_tedd.py
##########
@@ -14,9 +14,13 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-from tvm import te
-import numpy as np
import re
+
+import numpy as np
+
+import pytest
Review comment:
Is this needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leandron commented on pull request #6643: [TEST][TEDD] improve TEDD tests to also run on CPU Docker image
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #6643:
URL: https://github.com/apache/incubator-tvm/pull/6643#issuecomment-705443958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org