[GitHub] spark pull request #22602: [SPARK-25538][SQL] Zero-out all bytes when writin...

[kiszk <gi...@git.apache.org>]

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22602#discussion_r221792922
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java ---
    @@ -185,13 +185,13 @@ public void write(int ordinal, Decimal input, int precision, int scale) {
           // grow the global buffer before writing data.
           holder.grow(16);
     
    +      // zero-out the bytes
    --- End diff --
    
    nit: Can we refine a comment like the following to avoid this problem in the future?
    ```
    // always zero-out the 16-byte buffer
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org