You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/28 09:24:34 UTC
[GitHub] [incubator-devlake] klesh opened a new issue, #2367: [Feature][config-ui] config-ui new user flow stage 2
klesh opened a new issue, #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
## Hide passwords/tokens from connection settings pages
1. Change api `TestConnection` of github plugin to validate exactly 1 token, and return `username` for the token if succeeded.
2. `config-ui` github connection would call `TestConnection` for each token and print out `username` for them if succeeded, or an error message in red. For other plugins, making the input field to `password` type would be sufficient. @yumengwang03 will finish the design before 1st July, @e2corporation
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367#issuecomment-1168877874
> @klesh @Startrekzky What is the business value in revealing a username associated with a secure token and displaying it on the UI in the first place? Is backend going to discern username information from the token and provide that information in the connection object for each token? Is username going to be present in the API test response only? GitHub automatically emails users regarding expired tokens or tokens that are about to expire.
No, it has nothing to do with the BE.
Yes, the `username` is going to be present in API test response only.
Email notification for github token, maybe, I'm not sure. But it has nothing to do with the design AFAIK, from what I learned from @yumengwang03, it is for the user who has multiple tokens from different colleagues, so the user could identify which ones are expired, and reach out to the owner easily, plus, the user can find out if there are duplicate `username` from these seemingly different tokens, and we can also check that for them as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
Startrekzky commented on issue #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367#issuecomment-1210380564
Closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367#issuecomment-1168875763
> > @klesh Why is #2249 being listed here for a ticket regarding Test Connection? That ticket is not a true description of what's happening on the Pipeline activity page, nor does it reflect the need for usage of `progressDetail`. I have already logged a ticket to address this issue regarding how Activity progress is calculated, it has not been added to any milestone as yet.
> > **Config-UI / Pipeline Activity / Progress Detail** #2197.
>
> Not sure, I didn't create any of it... We can close one if you think they are duplicated. And I have to mention once more: percentage progress is a big NO NO, NOT all subtasks return `progressDetail.totalRecords`, as a matter of fact, many of them return `-1` when it is unavailable. And even if we have only one subtask which can not return this information, it breaks the percentage progress.
I understand the need for showing this information, I'm not against making any of these changes, if it was a true priority like you stated it would have been added to a milestone and brought up at weekly standup as a priority ticket that needs to be implemented. I've been busy with feature development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367#issuecomment-1168816889
@klesh Why is #2229 being listed here for a ticket regarding Test Connection? That ticket is not a true description of what's happening on the Pipeline activity page, nor does it reflect the need for usage of `progressDetail`. I have already logged a ticket to address this issue regarding how Activity progress is calculated, it has not been added to any milestone as yet.
https://github.com/apache/incubator-devlake/issues/2197.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367#issuecomment-1168864196
> @klesh Why is #2249 being listed here for a ticket regarding Test Connection? That ticket is not a true description of what's happening on the Pipeline activity page, nor does it reflect the need for usage of `progressDetail`. I have already logged a ticket to address this issue regarding how Activity progress is calculated, it has not been added to any milestone as yet.
>
> **Config-UI / Pipeline Activity / Progress Detail** #2197.
Not sure, I didn't create any of it... We can close one if you think they are duplicated.
And I have to mention once more: percentage progress is a big NO NO, NOT all subtasks return `progressDetail.totalRecords`, as a matter of fact, many of them return `-1` when it is unavailable. And even if we have only one subtask which can not return this information, it breaks the percentage progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky closed issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
Startrekzky closed issue #2367: [Feature][config-ui] config-ui new user flow stage 2
URL: https://github.com/apache/incubator-devlake/issues/2367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] yumengwang03 commented on issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
yumengwang03 commented on issue #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367#issuecomment-1173833429
The issue for downloading the full pipeline log: https://github.com/apache/incubator-devlake/issues/2413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367#issuecomment-1168851226
@klesh @klesh What is the business value in revealing a username associated with a secure token and displaying it on the UI in the first place? Is backend going to discern username information from the token and provide that information in the connection object for each token? Is username going to be present in the API test response only? GitHub automatically emails users regarding expired tokens or tokens that are about to expire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367#issuecomment-1168969852
> > @klesh @Startrekzky What is the business value in revealing a username associated with a secure token and displaying it on the UI in the first place? Is backend going to discern username information from the token and provide that information in the connection object for each token? Is username going to be present in the API test response only? GitHub automatically emails users regarding expired tokens or tokens that are about to expire.
>
> No, it has nothing to do with the BE.
>
> Yes, the `username` is going to be present in API test response only.
>
> Email notification for github token, maybe, I'm not sure. But it has nothing to do with the design AFAIK, from what I learned from @yumengwang03, it is for the user who has multiple tokens from different colleagues, so the user could identify which ones are expired, and reach out to the owner easily, plus, the user can find out if there are duplicate `username` from these seemingly different tokens, and we can also check that for them as well.
If API is providing this information with the API response, we can get this information displayed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #2367: [Feature][config-ui] config-ui new user flow stage 2
Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2367:
URL: https://github.com/apache/incubator-devlake/issues/2367#issuecomment-1168879164
> > > @klesh Why is #2249 being listed here for a ticket regarding Test Connection? That ticket is not a true description of what's happening on the Pipeline activity page, nor does it reflect the need for usage of `progressDetail`. I have already logged a ticket to address this issue regarding how Activity progress is calculated, it has not been added to any milestone as yet.
> > > **Config-UI / Pipeline Activity / Progress Detail** #2197.
> >
> >
> > Not sure, I didn't create any of it... We can close one if you think they are duplicated. And I have to mention once more: percentage progress is a big NO NO, NOT all subtasks return `progressDetail.totalRecords`, as a matter of fact, many of them return `-1` when it is unavailable. And even if we have only one subtask which can not return this information, it breaks the percentage progress.
>
> I understand the need for showing this information, I'm not against making any of these changes, if it was a true priority like you stated it would have been added to a milestone and brought up at weekly standup as a priority ticket that needs to be implemented. I've been busy with feature development.
Aah, sorry, it is for next month... I should have said that before everything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org