You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2024/06/05 18:02:36 UTC

Change in asterixdb[master]: WIP: Compilation error with query

From Peeyush Gupta <pe...@couchbase.com>:

Peeyush Gupta has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18342 )


Change subject: WIP: Compilation error with query
......................................................................

WIP: Compilation error with query

Change-Id: I5e34dabbbb6e5d266c2ea314f1f3c708d550ca73
---
M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SelectOperator.java
1 file changed, 25 insertions(+), 2 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/42/18342/1

diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SelectOperator.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SelectOperator.java
index 3bcf29c..2d2910f 100644
--- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SelectOperator.java
+++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SelectOperator.java
@@ -129,9 +129,24 @@
             return env;
         }
         AbstractFunctionCallExpression f1 = (AbstractFunctionCallExpression) condition.getValue();
-        if (!f1.getFunctionIdentifier().equals(AlgebricksBuiltinFunctions.NOT)) {
+        if (f1.getFunctionIdentifier().equals(AlgebricksBuiltinFunctions.AND)) {
+            for (Mutable<ILogicalExpression> a1 : f1.getArguments()) {
+                if (a1.getValue().getExpressionTag() == LogicalExpressionTag.FUNCTION_CALL) {
+                    computeMissableNullAble(env, (AbstractFunctionCallExpression) a1.getValue());
+                }
+            }
             return env;
         }
+        if (f1.getFunctionIdentifier().equals(AlgebricksBuiltinFunctions.NOT)) {
+            computeMissableNullAble(env, f1);
+        }
+        return env;
+    }
+
+    private void computeMissableNullAble(PropagatingTypeEnvironment env, AbstractFunctionCallExpression f1) {
+        if (!f1.getFunctionIdentifier().equals(AlgebricksBuiltinFunctions.NOT)) {
+            return;
+        }
         ILogicalExpression a1 = f1.getArguments().get(0).getValue();
         if (a1.getExpressionTag() == LogicalExpressionTag.FUNCTION_CALL) {
             AbstractFunctionCallExpression f2 = (AbstractFunctionCallExpression) a1;
@@ -142,7 +157,6 @@
                 extractFunctionArgVarInto(f2, env.getNonNullableVariables());
             }
         }
-        return env;
     }
 
     @Override

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18342
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I5e34dabbbb6e5d266c2ea314f1f3c708d550ca73
Gerrit-Change-Number: 18342
Gerrit-PatchSet: 1
Gerrit-Owner: Peeyush Gupta <pe...@couchbase.com>
Gerrit-MessageType: newchange