You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2018/12/05 09:44:35 UTC

[04/14] james-project git commit: MAILBOX-355 Solve intelliJ warnings in DefaultUserQuotaRootResolverTest

MAILBOX-355 Solve intelliJ warnings in DefaultUserQuotaRootResolverTest


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/9494a119
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/9494a119
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/9494a119

Branch: refs/heads/master
Commit: 9494a119d26844e063aa5d2afca66ab20d0037c0
Parents: 985b9a4
Author: Benoit Tellier <bt...@linagora.com>
Authored: Tue Dec 4 10:10:28 2018 +0700
Committer: Benoit Tellier <bt...@linagora.com>
Committed: Wed Dec 5 16:33:30 2018 +0700

----------------------------------------------------------------------
 .../quota/DefaultUserQuotaRootResolverTest.java   | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/9494a119/mailbox/store/src/test/java/org/apache/james/mailbox/store/quota/DefaultUserQuotaRootResolverTest.java
----------------------------------------------------------------------
diff --git a/mailbox/store/src/test/java/org/apache/james/mailbox/store/quota/DefaultUserQuotaRootResolverTest.java b/mailbox/store/src/test/java/org/apache/james/mailbox/store/quota/DefaultUserQuotaRootResolverTest.java
index 92b9f6c..367d476 100644
--- a/mailbox/store/src/test/java/org/apache/james/mailbox/store/quota/DefaultUserQuotaRootResolverTest.java
+++ b/mailbox/store/src/test/java/org/apache/james/mailbox/store/quota/DefaultUserQuotaRootResolverTest.java
@@ -40,10 +40,10 @@ public class DefaultUserQuotaRootResolverTest {
 
     public static final MailboxPath MAILBOX_PATH = MailboxPath.forUser("benwa", "INBOX");
     public static final SimpleMailbox MAILBOX = new SimpleMailbox(MAILBOX_PATH, 10);
-    public static final MailboxPath PATH_LIKE = MailboxPath.forUser("benwa", "%");
-    public static final MailboxPath MAILBOX_PATH_2 = MailboxPath.forUser("benwa", "test");
-    public static final SimpleMailbox MAILBOX_2 = new SimpleMailbox(MAILBOX_PATH_2, 10);
-    public static final QuotaRoot QUOTA_ROOT = QuotaRoot.quotaRoot("#private&benwa", Optional.empty());
+    private static final MailboxPath PATH_LIKE = MailboxPath.forUser("benwa", "%");
+    private static final MailboxPath MAILBOX_PATH_2 = MailboxPath.forUser("benwa", "test");
+    private static final SimpleMailbox MAILBOX_2 = new SimpleMailbox(MAILBOX_PATH_2, 10);
+    private static final QuotaRoot QUOTA_ROOT = QuotaRoot.quotaRoot("#private&benwa", Optional.empty());
 
     private DefaultUserQuotaRootResolver testee;
     private MailboxSessionMapperFactory mockedFactory;
@@ -55,22 +55,22 @@ public class DefaultUserQuotaRootResolverTest {
     }
 
     @Test
-    public void getQuotaRootShouldReturnUserRelatedQuotaRoot() throws Exception {
+    public void getQuotaRootShouldReturnUserRelatedQuotaRoot() {
         assertThat(testee.getQuotaRoot(MAILBOX_PATH)).isEqualTo(QUOTA_ROOT);
     }
 
     @Test(expected = IllegalArgumentException.class)
-    public void getQuotaRootShouldThrowWhenNamespaceContainsSeparator() throws Exception {
+    public void getQuotaRootShouldThrowWhenNamespaceContainsSeparator() {
         testee.getQuotaRoot(new MailboxPath("#pr&ivate", "benwa", "INBOX"));
     }
 
     @Test(expected = IllegalArgumentException.class)
-    public void getQuotaRootShouldThrowWhenUserContainsSeparator() throws Exception {
+    public void getQuotaRootShouldThrowWhenUserContainsSeparator() {
         testee.getQuotaRoot(MailboxPath.forUser("ben&wa", "INBOX"));
     }
 
     @Test
-    public void getQuotaRootShouldWorkWhenUserIsNull() throws Exception {
+    public void getQuotaRootShouldWorkWhenUserIsNull() {
         QuotaRoot quotaRoot = testee.getQuotaRoot(new MailboxPath("#private", null, "INBOX"));
 
         assertThat(quotaRoot).isEqualTo(QuotaRoot.quotaRoot("#private", Optional.empty()));
@@ -78,7 +78,7 @@ public class DefaultUserQuotaRootResolverTest {
 
     @Test
     public void retrieveAssociatedMailboxesShouldWork() throws Exception {
-        final MailboxMapper mockedMapper = mock(MailboxMapper.class);
+        MailboxMapper mockedMapper = mock(MailboxMapper.class);
         when(mockedFactory.getMailboxMapper(null)).thenReturn(mockedMapper);
         when(mockedMapper.findMailboxWithPathLike(PATH_LIKE)).thenReturn(Lists.newArrayList(MAILBOX, MAILBOX_2));
         assertThat(testee.retrieveAssociatedMailboxes(QUOTA_ROOT, null)).containsOnly(MAILBOX_PATH, MAILBOX_PATH_2);


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org