[GitHub] [skywalking-python] kezhenxu94 commented on pull request #93: [Fix][Plugin] sw_flask general exceptions handled

[GitBox <gi...@apache.org>]

kezhenxu94 commented on pull request #93:
URL: https://github.com/apache/skywalking-python/pull/93#issuecomment-739073245


   > Just a random question but ... why are the meanings of span.inject() and span.extract() inverted between the Python and Node agents? Which one has it right?
   
   Python has it right. 
   
   > Question about `SpanContext.new_entry_span()` and `.new_exit_span()`, should `span.inject()` / `.extract()` be called on every call to new_? as it is now or only when the Span is created for the first time?
   
   Should be called on every call to `new_{entry,exit}_span}`, this is for cross-service context propagation, otherwise, the traces would break into pieces (per service)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org