You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Siddharth Seth (JIRA)" <ji...@apache.org> on 2011/05/17 01:46:48 UTC
[jira] [Created] (MAPREDUCE-2500) MR 279: PB factories are not
thread safe
MR 279: PB factories are not thread safe
----------------------------------------
Key: MAPREDUCE-2500
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2500
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Reporter: Siddharth Seth
Assignee: Siddharth Seth
Fix For: 0.23.0
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2500) MR 279: PB factories are not
thread safe
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-2500:
--------------------------------------
Attachment: MR2500_3.patch
Thanks for taking a look Luke.
Patch with the suggested changes.
> MR 279: PB factories are not thread safe
> ----------------------------------------
>
> Key: MAPREDUCE-2500
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2500
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 0.23.0
>
> Attachments: MR2500.patch, MR2500_2.patch, MR2500_3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2500) MR 279: PB factories are not
thread safe
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-2500:
--------------------------------------
Attachment: MR2500.patch
Factories changed to use a ConcurrentMap - doesn't really matter if two parallel calls end up creating their own instances (instead of using a cached copy).
Changed FactoryProvider to use a static configuration object if none is provided (instead of creating a configuration each time)
Changed TypeConverter to use a static RecordFactory. (To be changed later to use a provided recordFactory)
> MR 279: PB factories are not thread safe
> ----------------------------------------
>
> Key: MAPREDUCE-2500
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2500
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 0.23.0
>
> Attachments: MR2500.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2500) MR 279: PB factories are not
thread safe
Posted by "Luke Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034463#comment-13034463 ]
Luke Lu commented on MAPREDUCE-2500:
------------------------------------
Minor nits:
# The ctor lookup code probably should save the lookup result instead make another cache.get call.
# You can probably get rid of the null in clazz.getConstructor(null) in RecordFactoryPBImpl to avoid the vararg warning.
> MR 279: PB factories are not thread safe
> ----------------------------------------
>
> Key: MAPREDUCE-2500
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2500
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 0.23.0
>
> Attachments: MR2500.patch, MR2500_2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2500) MR 279: PB factories are not
thread safe
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-2500:
--------------------------------------
Attachment: MR2500_2.patch
Same as the previous patch - with the apache license added.
> MR 279: PB factories are not thread safe
> ----------------------------------------
>
> Key: MAPREDUCE-2500
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2500
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 0.23.0
>
> Attachments: MR2500.patch, MR2500_2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2500) MR 279: PB factories are not
thread safe
Posted by "Luke Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034435#comment-13034435 ]
Luke Lu commented on MAPREDUCE-2500:
------------------------------------
+1, lgtm.
> MR 279: PB factories are not thread safe
> ----------------------------------------
>
> Key: MAPREDUCE-2500
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2500
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 0.23.0
>
> Attachments: MR2500.patch, MR2500_2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAPREDUCE-2500) MR 279: PB factories are not
thread safe
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar resolved MAPREDUCE-2500.
--------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
I just pushed this to MR-279. thanks sid and luke!
> MR 279: PB factories are not thread safe
> ----------------------------------------
>
> Key: MAPREDUCE-2500
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2500
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 0.23.0
>
> Attachments: MR2500.patch, MR2500_2.patch, MR2500_3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira