[GitHub] [spark] pgandhi999 opened a new pull request #24134: [SPARK-27112][CORE] : Create a resource ordering between threads to r…

[GitBox <gi...@apache.org>]

pgandhi999 opened a new pull request #24134: [SPARK-27112][CORE] : Create a resource ordering between threads to r…
URL: https://github.com/apache/spark/pull/24134
 
 
   …esolve the deadlocks encountered …
   
   …when trying to kill executors either due to dynamic allocation or blacklisting
   
   There are two deadlocks as a result of the interplay between three different threads:
   
   **task-result-getter thread**
   
   **spark-dynamic-executor-allocation thread**
   
   **dispatcher-event-loop thread(makeOffers())**
   
   The fix ensures ordering synchronization constraint by acquiring lock on `TaskSchedulerImpl` before acquiring lock on `CoarseGrainedSchedulerBackend` in `makeOffers()` as well as killExecutors() method. This ensures resource ordering between the threads and thus, fixes the deadlocks.
   
   Manual Tests
   
   Closes #24072 from pgandhi999/SPARK-27112-2.
   
   Authored-by: pgandhi <pg...@verizonmedia.com>
   Signed-off-by: Imran Rashid <ir...@cloudera.com>
   
   ## What changes were proposed in this pull request?
   
   (Please fill in changes proposed in this fix)
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
   (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
   
   Please review http://spark.apache.org/contributing.html before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org