You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2024/09/28 21:59:11 UTC

Re: [PR] Remove ShardingSphereSchema.dataSourcesMetaData [shardingsphere]

codecov-commenter commented on PR #8042:
URL: https://github.com/apache/shardingsphere/pull/8042#issuecomment-2381005201

   ## [Codecov](https://app.codecov.io/gh/apache/shardingsphere/pull/8042?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `81.25000%` with `3 lines` in your changes missing coverage. Please review.
   > Project coverage is 75.12%. Comparing base [(`37651f3`)](https://app.codecov.io/gh/apache/shardingsphere/commit/37651f3aca8e05042be192ce7a08bbaa31fee6d8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`970e3cb`)](https://app.codecov.io/gh/apache/shardingsphere/commit/970e3cb289ad944e5a3f3905ceaf58cbaca1879a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 16434 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/shardingsphere/pull/8042?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ource/metadata/ShardingSphereDatabaseMetaData.java](https://app.codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=tree&filepath=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fdatasource%2Fmetadata%2FShardingSphereDatabaseMetaData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvZGF0YXNvdXJjZS9tZXRhZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFiYXNlTWV0YURhdGEuamF2YQ==) | 33.33% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../route/engine/type/ShardingRouteEngineFactory.java](https://app.codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=tree&filepath=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Ftype%2FShardingRouteEngineFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL1NoYXJkaW5nUm91dGVFbmdpbmVGYWN0b3J5LmphdmE=) | 90.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/8042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8042      +/-   ##
   ============================================
   - Coverage     75.12%   75.12%   -0.01%     
     Complexity      547      547              
   ============================================
     Files          1447     1447              
     Lines         22701    22704       +3     
     Branches       4049     4049              
   ============================================
   + Hits          17055    17057       +2     
     Misses         4545     4545              
   - Partials       1101     1102       +1     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shardingsphere/pull/8042?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org