You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dave Watson (JIRA)" <ji...@apache.org> on 2011/09/09 02:20:08 UTC
[jira] [Created] (THRIFT-1336) thrift: added server and processor
test code
thrift: added server and processor test code
----------------------------------------------
Key: THRIFT-1336
URL: https://issues.apache.org/jira/browse/THRIFT-1336
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
Attachments: 0032-thrift-added-server-and-processor-test-code.patch
davejwatson:
Internally FB uses a different build system. I added stuff to the Makefile.am
for these tests, but I'm not a makefile master, it would be nice to have
a second set of eyes here
>From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
From: Adam Simpkins <si...@fb.com>
Date: Fri, 23 Apr 2010 04:19:18 +0000
Subject: [PATCH 32/33] thrift: added server and processor test code
Summary:
This code tests that the TServerEventHandler and TProcessorEventHandler
hooks are invoked correctly by the server and event code. The test
cases all start a server in a separate thread, then make some calls
against it. The TServerEventHandler and TProcessorEventHandler record
each time they are called, and the test code checks to make sure that
the recorded calls match what is expected.
Test Plan:
Ran it.
Currently it fails for several reasons. Several of the servers don't
implement stop() properly, causing tests to hang trying to shutdown
their server. TNonblockingServer also doesn't invoke the
TProcessorEventHandler correctly when not using a ThreadManager.
I have fixes for all of these, which I'll submit as separate diffs.
Revert Plan:
OK
---
lib/cpp/Makefile.am | 47 ++-
lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
lib/cpp/src/processor/test/EventLog.h | 94 +++
lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
lib/cpp/src/processor/test/ServerThread.h | 143 ++++
lib/cpp/src/processor/test/proc.thrift | 22 +
8 files changed, 1863 insertions(+), 2 deletions(-)
create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
create mode 100644 lib/cpp/src/processor/test/EventLog.h
create mode 100644 lib/cpp/src/processor/test/Handlers.h
create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
create mode 100644 lib/cpp/src/processor/test/ServerThread.h
create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1336) thrift: added server and
processor test code
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273289#comment-13273289 ]
Hudson commented on THRIFT-1336:
--------------------------------
Integrated in Thrift #466 (See [https://builds.apache.org/job/Thrift/466/])
THRIFT-1336 thrift: added server and processor test code
disable processor_test ... does not run properly on build slaves (Revision 1337162)
Result = ABORTED
roger : http://svn.apache.org/viewvc/?view=rev&rev=1337162
Files :
* /thrift/trunk/lib/cpp/test/Makefile.am
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Roger Meier
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1336) thrift: added server and
processor test code
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272890#comment-13272890 ]
Hudson commented on THRIFT-1336:
--------------------------------
Integrated in Thrift #460 (See [https://builds.apache.org/job/Thrift/460/])
fix broken build introduced with THRIFT-1336 (Revision 1336895)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1336895
Files :
* /thrift/trunk/lib/cpp/Makefile.am
* /thrift/trunk/test/Makefile.am
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1336) thrift: added server and processor
test code
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1336.
---------------------------------
Resolution: Fixed
Assignee: Dave Watson
did some rework to fit new layout and committed
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1336) thrift: added server and
processor test code
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273264#comment-13273264 ]
Roger Meier commented on THRIFT-1336:
-------------------------------------
disable processor_test ... does not run properly on build slaves
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Roger Meier
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1336) thrift: added server and
processor test code
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281877#comment-13281877 ]
Hudson commented on THRIFT-1336:
--------------------------------
Integrated in Thrift #487 (See [https://builds.apache.org/job/Thrift/487/])
THRIFT-1336 thrift: added server and processor test code
revert partly: disable processor test, it breaks the builds (Revision 1341996)
Result = FAILURE
roger : http://svn.apache.org/viewvc/?view=rev&rev=1341996
Files :
* /thrift/trunk/lib/cpp/test/Makefile.am
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Roger Meier
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1336) thrift: added server and
processor test code
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273339#comment-13273339 ]
Hudson commented on THRIFT-1336:
--------------------------------
Integrated in Thrift #467 (See [https://builds.apache.org/job/Thrift/467/])
THRIFT-1336 thrift: added server and processor test code
last commit was wrong! otherway around!
disable concurrency instead of processor_test ... does not run properly on build slaves (Revision 1337177)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1337177
Files :
* /thrift/trunk/lib/cpp/test/Makefile.am
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Roger Meier
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1336) thrift: added server and processor
test code
Posted by "Dave Watson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Watson updated THRIFT-1336:
--------------------------------
Attachment: 0032-thrift-added-server-and-processor-test-code.patch
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1336) thrift: added server and
processor test code
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273164#comment-13273164 ]
Hudson commented on THRIFT-1336:
--------------------------------
Integrated in Thrift #464 (See [https://builds.apache.org/job/Thrift/464/])
THRIFT-1336 thrift: added server and processor test code
move the tests from src to test:
lib\cpp\src\thrift\concurrency\test to lib\cpp\test\concurrency
lib\cpp\src\thrift\processor\test to lib\cpp\test\processor (Revision 1337098)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1337098
Files :
* /thrift/trunk/lib/cpp/Makefile.am
* /thrift/trunk/lib/cpp/src/thrift/concurrency/test/Tests.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/test/ThreadFactoryTests.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/test/ThreadManagerTests.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/test/TimerManagerTests.h
* /thrift/trunk/lib/cpp/src/thrift/processor/test/EventLog.cpp
* /thrift/trunk/lib/cpp/src/thrift/processor/test/EventLog.h
* /thrift/trunk/lib/cpp/src/thrift/processor/test/Handlers.h
* /thrift/trunk/lib/cpp/src/thrift/processor/test/ProcessorTest.cpp
* /thrift/trunk/lib/cpp/src/thrift/processor/test/ServerThread.cpp
* /thrift/trunk/lib/cpp/src/thrift/processor/test/ServerThread.h
* /thrift/trunk/lib/cpp/src/thrift/processor/test/proc.thrift
* /thrift/trunk/lib/cpp/test/Makefile.am
* /thrift/trunk/lib/cpp/test/concurrency
* /thrift/trunk/lib/cpp/test/concurrency/Tests.cpp
* /thrift/trunk/lib/cpp/test/concurrency/ThreadFactoryTests.h
* /thrift/trunk/lib/cpp/test/concurrency/ThreadManagerTests.h
* /thrift/trunk/lib/cpp/test/concurrency/TimerManagerTests.h
* /thrift/trunk/lib/cpp/test/processor
* /thrift/trunk/lib/cpp/test/processor/EventLog.cpp
* /thrift/trunk/lib/cpp/test/processor/EventLog.h
* /thrift/trunk/lib/cpp/test/processor/Handlers.h
* /thrift/trunk/lib/cpp/test/processor/ProcessorTest.cpp
* /thrift/trunk/lib/cpp/test/processor/ServerThread.cpp
* /thrift/trunk/lib/cpp/test/processor/ServerThread.h
* /thrift/trunk/lib/cpp/test/processor/proc.thrift
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Roger Meier
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1336) thrift: added server and
processor test code
Posted by "Roger Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167178#comment-13167178 ]
Roger Meier commented on THRIFT-1336:
-------------------------------------
Thanks Dave, I'm a big fan of Unit Tests!
one issue...patch does not apply anymore...
one wish...could you place the tests within lib/cpp/test where the other test are located and invoked by make check.
-roger
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1336) thrift: added server and
processor test code
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273197#comment-13273197 ]
Roger Meier commented on THRIFT-1336:
-------------------------------------
change committed!
however concurrency_test seems to heavy for the build server...
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Roger Meier
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (THRIFT-1336) thrift: added server and processor
test code
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier reopened THRIFT-1336:
---------------------------------
Assignee: Roger Meier (was: Dave Watson)
I broke the build!
I will fix this and move the tests from src to test:
lib\cpp\src\thrift\concurrency\test to lib\cpp\test\concurrency
lib\cpp\src\thrift\processor\test to lib\cpp\test\processor
very soon
-roger
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Roger Meier
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1336) thrift: added server and
processor test code
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272324#comment-13272324 ]
Hudson commented on THRIFT-1336:
--------------------------------
Integrated in Thrift #459 (See [https://builds.apache.org/job/Thrift/459/])
THRIFT-1336 thrift: added server and processor test code
Patch: Dave Watson
- rework made by roger (Revision 1336544)
Result = FAILURE
roger : http://svn.apache.org/viewvc/?view=rev&rev=1336544
Files :
* /thrift/trunk/lib/cpp/Makefile.am
* /thrift/trunk/lib/cpp/src/thrift/processor/test
* /thrift/trunk/lib/cpp/src/thrift/processor/test/EventLog.cpp
* /thrift/trunk/lib/cpp/src/thrift/processor/test/EventLog.h
* /thrift/trunk/lib/cpp/src/thrift/processor/test/Handlers.h
* /thrift/trunk/lib/cpp/src/thrift/processor/test/ProcessorTest.cpp
* /thrift/trunk/lib/cpp/src/thrift/processor/test/ServerThread.cpp
* /thrift/trunk/lib/cpp/src/thrift/processor/test/ServerThread.h
* /thrift/trunk/lib/cpp/src/thrift/processor/test/proc.thrift
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1336) thrift: added server and processor
test code
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1336.
---------------------------------
Resolution: Fixed
last commit was wrong! otherway around!
disable concurrency instead of processor_test ... does not run properly on build slaves
sorry!
> thrift: added server and processor test code
> ----------------------------------------------
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Roger Meier
> Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson:
> Internally FB uses a different build system. I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Fri, 23 Apr 2010 04:19:18 +0000
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code. The test
> cases all start a server in a separate thread, then make some calls
> against it. The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons. Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server. TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
> lib/cpp/Makefile.am | 47 ++-
> lib/cpp/src/processor/test/EventLog.cpp | 129 ++++
> lib/cpp/src/processor/test/EventLog.h | 94 +++
> lib/cpp/src/processor/test/Handlers.h | 341 ++++++++++
> lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++++++++++++++++++++++++++
> lib/cpp/src/processor/test/ServerThread.cpp | 148 ++++
> lib/cpp/src/processor/test/ServerThread.h | 143 ++++
> lib/cpp/src/processor/test/proc.thrift | 22 +
> 8 files changed, 1863 insertions(+), 2 deletions(-)
> create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
> create mode 100644 lib/cpp/src/processor/test/EventLog.h
> create mode 100644 lib/cpp/src/processor/test/Handlers.h
> create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
> create mode 100644 lib/cpp/src/processor/test/ServerThread.h
> create mode 100644 lib/cpp/src/processor/test/proc.thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira